src/ia32/full-codegen-ia32.cc - Issue 5686006: Add array bound checks to code generated for SwapElements. This fixes a bug t...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/full-codegen-ia32.cc

Issue 5686006: Add array bound checks to code generated for SwapElements. This fixes a bug t... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/full-codegen-ia32.cc

===================================================================

--- src/ia32/full-codegen-ia32.cc (revision 6016)

+++ src/ia32/full-codegen-ia32.cc (working copy)

@@ -3108,6 +3108,13 @@

__ test(temp, Immediate(kSmiTagMask));

__ j(not_zero, &slow_case);

+ // Check that both indices are valid.

+ __ mov(temp, FieldOperand(object, JSArray::kLengthOffset));

+ __ cmp(temp, Operand(index_1));

+ __ j(below_equal, &slow_case);

+ __ cmp(temp, Operand(index_2));

+ __ j(below_equal, &slow_case);

// Bring addresses into index1 and index2.

__ lea(index_1, CodeGenerator::FixedArrayElementOperand(elements, index_1));

__ lea(index_2, CodeGenerator::FixedArrayElementOperand(elements, index_2));

« no previous file with comments | « src/ia32/codegen-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »