Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 5686001: Ensure that custom cursors set by windowless flash plugins get marshaled corr... (Closed)

Created:
10 years ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Ensure that custom cursors set by windowless flash plugins get marshaled correctly back to the renderer and eventually to the browser. We rely on the HCURSOR getting marshaled across on windows. However this regressed when code to validate the custom cursor info was added in the WebCursor deserialization routines. Fixes bug http://code.google.com/p/chromium/issues/list?cursor=39436 BUG=39436 TEST=Covered by new custom cursor deserialization unit test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68759

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -21 lines) Patch
M webkit/glue/webcursor.cc View 1 chunk +18 lines, -17 lines 0 comments Download
M webkit/glue/webcursor_unittest.cc View 1 5 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years ago (2010-12-09 03:58:11 UTC) #1
jam
10 years ago (2010-12-09 19:03:05 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698