Issue 5685010: Postpone interrupts during marking garbage collection. This allows the check...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5685010: Postpone interrupts during marking garbage collection. This allows the check... (Closed)

Created:
10 years ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google), Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Postpone interrupts during marking garbage collection. This allows the check for C stack overflow to function correctly. Committed: http://code.google.com/p/v8/source/detail?r=6006

Patch Set 2 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	src/mark-compact.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

LGTM http://codereview.chromium.org/5685010/diff/1/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/5685010/diff/1/src/mark-compact.cc#newcode1284 src/mark-compact.cc:1284: PostponeInterruptsScope postpone; Please consider commenting why we need ...

10 years ago (2010-12-14 11:34:52 UTC) #2

William Hesse

10 years ago (2010-12-14 11:59:22 UTC) #3

http://codereview.chromium.org/5685010/diff/1/src/mark-compact.cc
File src/mark-compact.cc (right):

http://codereview.chromium.org/5685010/diff/1/src/mark-compact.cc#newcode1284
src/mark-compact.cc:1284: PostponeInterruptsScope postpone;
On 2010/12/14 11:34:52, Vyacheslav Egorov wrote:
> Please consider commenting why we need this scope here.

Done.

Expand Messages | Collapse Messages

Issue 5685010: Postpone interrupts during marking garbage collection. This allows the check... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages