Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 5685007: Rename all methods accessing Singleton<T> as GetInstance(). (Closed)

Created:
10 years ago by Satish
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, stuartmorgan+watch_chromium.org, Alpha Left Google, Sergey Ulanov, Erik does not do reviews, brettw-cc_chromium.org, jam, Aaron Boodman, dmac, pam+watch_chromium.org, awong, garykac, Paweł Hajdan Jr., darin-cc_chromium.org, amit, davemoore+watch_chromium.org, ceee-reviews_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Rename all methods accessing Singleton<T> as GetInstance(). This is in preparation to a subsequent CL where Singleton<T> will restrict access to only the type being made singleton. I also moved pepper::ResourceTracker to a lazy instance since there were too many places in code where this class was being accessed from and this was a smaller change than renaming methods in that case. BUG=65298 TEST=all existing tests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68982

Patch Set 1 #

Total comments: 7

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+217 lines, -194 lines) Patch
M app/active_window_watcher_x.h View 1 chunk +2 lines, -0 lines 0 comments Download
M app/active_window_watcher_x.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M app/surface/io_surface_support_mac.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M base/debug/stack_trace_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ceee/common/process_utils_win.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ceee/common/process_utils_win.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M ceee/ie/broker/executors_manager.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/about_flags.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/background_page_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/background_page_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_about_handler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/browser_main.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/browser_shutdown.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cert_store.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cert_store.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/certificate_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsing_context.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_browsing_context.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_plugin_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/dom_ui/conflicts_ui.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/dom_ui/plugins_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/enumerate_modules_model_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_bookmarks_module.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/extension_host.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extensions_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu_process_host_ui_shim.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gpu_process_host_ui_shim.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/net/metadata_url_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/page_info_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/parsers/metadata_parser_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/parsers/metadata_parser_manager.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/plugin_process_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/plugin_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_updater.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/plugin_updater.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/remoting/remoting_setup_flow.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/renderer_host/browser_render_process_host.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/resource_dispatcher_host.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/resource_message_filter.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control_browsertest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/service/service_process_control_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/service/service_process_control_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_blocking_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ssl/ssl_error_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_init.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/about_ipc_controller.mm View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/page_info_bubble_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_model.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/toolbar/wrench_menu_model.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/about_ipc_dialog.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/accessible_pane_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/html_dialog_view_browsertest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/page_info_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_gtk.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/tab_contents_view_win.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/toolbar_view.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/child_process_host.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/child_thread.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/extension.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/service_ipc_server.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/gpu/gpu_pixel_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/chrome_frame_activex.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/chrome_frame_activex_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/simple_resource_loader.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome_frame/simple_resource_loader.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome_frame/test/simple_resource_loader_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_posix.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M ipc/ipc_channel_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_logging.h View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_logging.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/registry_controlled_domain.h View 2 chunks +5 lines, -5 lines 0 comments Download
M views/focus/external_focus_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/focus_manager.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M views/focus/view_storage.h View 1 chunk +1 line, -1 line 0 comments Download
M views/focus/view_storage.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M views/widget/root_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/appcache/appcache_interceptor.h View 3 chunks +3 lines, -5 lines 0 comments Download
M webkit/appcache/appcache_interceptor.cc View 1 chunk +7 lines, -2 lines 0 comments Download
M webkit/glue/webkitclient_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Satish
10 years ago (2010-12-12 23:28:41 UTC) #1
Nico
LG Ignore the "Does this have to become public?" question below. http://codereview.chromium.org/5685007/diff/1/chrome/browser/renderer_host/resource_dispatcher_host.cc File chrome/browser/renderer_host/resource_dispatcher_host.cc (right): ...
10 years ago (2010-12-12 23:42:47 UTC) #2
Satish
10 years ago (2010-12-13 08:16:29 UTC) #3 
Thanks for the quick review.

http://codereview.chromium.org/5685007/diff/1/chrome/browser/renderer_host/re...
File chrome/browser/renderer_host/resource_dispatcher_host.cc (right):

http://codereview.chromium.org/5685007/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/resource_dispatcher_host.cc:1165:
info->child_id());
On 2010/12/12 23:42:47, Nico wrote:
> indent

Done.

http://codereview.chromium.org/5685007/diff/1/chrome/browser/renderer_host/re...
chrome/browser/renderer_host/resource_dispatcher_host.cc:1599: child_id);
On 2010/12/12 23:42:47, Nico wrote:
> indent

Done.

http://codereview.chromium.org/5685007/diff/1/webkit/glue/plugins/pepper_reso...
File webkit/glue/plugins/pepper_resource_tracker.cc (right):

http://codereview.chromium.org/5685007/diff/1/webkit/glue/plugins/pepper_reso...
webkit/glue/plugins/pepper_resource_tracker.cc:17: base::LINKER_INITIALIZED);
On 2010/12/12 23:42:47, Nico wrote:
> can you move this file to a different CL since the change here is something
> unrelated?

Done.

Powered by Google App Engine
This is Rietveld 408576698