chrome/browser/web_resource/web_resource_service.cc - Issue 5685004: Fix sync in Chromium-os by not allowing CanShowPromo to initialize the sync s...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/web_resource_service.cc

Issue 5685004: Fix sync in Chromium-os by not allowing CanShowPromo to initialize the sync s... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/web_resource/web_resource_service.cc

===================================================================

--- chrome/browser/web_resource/web_resource_service.cc (revision 68772)

+++ chrome/browser/web_resource/web_resource_service.cc (working copy)

@@ -519,9 +519,10 @@

}

bool promo_options =

- sync_ui_util::GetStatus(

- profile->GetProfileSyncService()) == sync_ui_util::SYNCED ||

- has_extensions;

+ (profile->HasProfileSyncService() &&

+ sync_ui_util::GetStatus(

+ profile->GetProfileSyncService()) == sync_ui_util::SYNCED) ||

+ has_extensions;

stevenjb 2010/12/10 17:40:47 We should add a comment here that mentions that Ha

return !promo_closed &&

promo_options &&

« no previous file with comments | « no previous file | no next file » | no next file with comments »