Fix sync in Chromium-os by not allowing CanShowPromo to initialize the sync s...

Fix sync in Chromium-os by not allowing CanShowPromo to initialize the sync system.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=10031
TEST=cros sync works


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68872

[Chris Masone, 2010-12-10 17:12:34]

I know you didn't ask me, but LGTM :-)

[stevenjb, 2010-12-10 17:40:47]

LGTM with nit.

http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
File chrome/browser/web_resource/web_resource_service.cc (right):

http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
chrome/browser/web_resource/web_resource_service.cc:526: 
We should add a comment here that mentions that HasProfileSyncService() will be
false for ChromeOS, so promo_options will always be false, and reference
http://crosbug/10209.

[Miranda Callahan, 2010-12-10 18:24:52]

On 2010/12/10 17:40:47, Steven Bennetts wrote:
> LGTM with nit.
> 
>
http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
> File chrome/browser/web_resource/web_resource_service.cc (right):
> 
>
http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
> chrome/browser/web_resource/web_resource_service.cc:526: 
> We should add a comment here that mentions that HasProfileSyncService() will
be
> false for ChromeOS, so promo_options will always be false, and reference
> http://crosbug/10209.

Will do -- though promo_options should still be true if the ChromeOS user has an
extension installed (if this concept is meaningful in the cros world).

[stevenjb (google-dont-use), 2010-12-10 18:38:47]

Ah, good point, in fact I knew that. Still probably worth having a comment
explaining why we do the check first.

On Fri, Dec 10, 2010 at 10:24 AM, <mirandac@chromium.org> wrote:

> On 2010/12/10 17:40:47, Steven Bennetts wrote:
>
>> LGTM with nit.
>>
>
>
>
>
http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
>
>> File chrome/browser/web_resource/web_resource_service.cc (right):
>>
>
>
>
>
http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
>
>> chrome/browser/web_resource/web_resource_service.cc:526:
>> We should add a comment here that mentions that HasProfileSyncService()
>> will
>>
> be
>
>> false for ChromeOS, so promo_options will always be false, and reference
>> http://crosbug/10209.
>>
>
> Will do -- though promo_options should still be true if the ChromeOS user
> has an
> extension installed (if this concept is meaningful in the cros world).
>
>
> http://codereview.chromium.org/5685004/
>

[Miranda Callahan, 2010-12-10 18:45:01]

Agreed -- comment added.

On 2010/12/10 18:38:47, stevenjb wrote:
> Ah, good point, in fact I knew that. Still probably worth having a comment
> explaining why we do the check first.
> 
> On Fri, Dec 10, 2010 at 10:24 AM, <mailto:mirandac@chromium.org> wrote:
> 
> > On 2010/12/10 17:40:47, Steven Bennetts wrote:
> >
> >> LGTM with nit.
> >>
> >
> >
> >
> >
>
http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
> >
> >> File chrome/browser/web_resource/web_resource_service.cc (right):
> >>
> >
> >
> >
> >
>
http://codereview.chromium.org/5685004/diff/9002/chrome/browser/web_resource/...
> >
> >> chrome/browser/web_resource/web_resource_service.cc:526:
> >> We should add a comment here that mentions that HasProfileSyncService()
> >> will
> >>
> > be
> >
> >> false for ChromeOS, so promo_options will always be false, and reference
> >> http://crosbug/10209.
> >>
> >
> > Will do -- though promo_options should still be true if the ChromeOS user
> > has an
> > extension installed (if this concept is meaningful in the cros world).
> >
> >
> > http://codereview.chromium.org/5685004/
> >

[stevenjb, 2010-12-10 19:18:49]

LGTM