Issue 5685002: Make it possible to write simple unit tests for the pepper implementation. Th...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5685002: Make it possible to write simple unit tests for the pepper implementation. Th... (Closed)

Created:
10 years ago by brettw

Modified:
9 years, 7 months ago

Reviewers:
viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make it possible to write simple unit tests for the pepper implementation. This adds a mock plugin delegate that does nothing, and a helper unit test base class that sets up a dummy plugin instance and module for use in writing tests. This implements some basic tests on the resource tracker and fixes a bug I found! TEST=this is BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68781

Patch Set 1 #

Total comments: 2

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+512 lines, -2 lines)			Patch
A	webkit/glue/plugins/mock_plugin_delegate.h	View	1 chunk	+98 lines, -0 lines	1 comment	Download
A	webkit/glue/plugins/mock_plugin_delegate.cc	View	1 chunk	+187 lines, -0 lines	0 comments	Download
A	webkit/glue/plugins/mock_resource.h	View	1 chunk	+25 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_plugin_delegate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/glue/plugins/pepper_resource.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource_tracker.h	View	4 chunks	+12 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/pepper_resource_tracker.cc	View	4 chunks	+18 lines, -1 line	0 comments	Download
A	webkit/glue/plugins/ppapi_unittest.h	View	1 chunk	+47 lines, -0 lines	1 comment	Download
A	webkit/glue/plugins/resource_tracker_unittest.cc	View	1 chunk	+116 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell.gypi	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

10 years ago (2010-12-09 20:41:02 UTC) #2

LGTM with whitespace fix.

http://codereview.chromium.org/5685002/diff/1/webkit/glue/plugins/mock_plugin...
File webkit/glue/plugins/mock_plugin_delegate.h (right):

http://codereview.chromium.org/5685002/diff/1/webkit/glue/plugins/mock_plugin...
webkit/glue/plugins/mock_plugin_delegate.h:5: #ifndef
WEBKIT_GLUE_PLUGINS_MOCK_PLUGIN_DELEGATE_H_
I assume this file is named with the pending file moves in mind, which is fine.

http://codereview.chromium.org/5685002/diff/1/webkit/glue/plugins/ppapi_unitt...
File webkit/glue/plugins/ppapi_unittest.h (right):

http://codereview.chromium.org/5685002/diff/1/webkit/glue/plugins/ppapi_unitt...
webkit/glue/plugins/ppapi_unittest.h:35: 
<style nit>

Expand Messages | Collapse Messages