Issue 5682012: Revert 69088 - Before starting translation reset cache in AutoFillManager. To...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5682012: Revert 69088 - Before starting translation reset cache in AutoFillManager. To... (Closed)

Created:
10 years ago by dhollowa

Modified:
9 years, 7 months ago

Reviewers:
dhollowa

CC:
chromium-reviews, James Hawkins, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org, Ilya Sherman, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 69088 - Before starting translation reset cache in AutoFillManager. To call Reset() function, append Reset() virtual function in RenderViewHostDelegate::AutoFill and derive it from AutoFillManager. BUG=58576 TEST= 1.launch English version Chrome 2. make sure autofill is enable and there is autofill data entry in settings 3.navigate to a non-English website e.g.: https://secure.fnac.pt/Account/Logon/LogonNewAccount.aspx?NID=-15&RNID=-15&PrevNID=0&pagepar=SID%3d22120814-4186-d926-4f7b-0dece96fade2|Origin%3dFnacAff|OrderInSession%3d1|TTL%3d070420110015|bl%3dHGAChead&PageRedir=https://www2.fnac.pt/Account/Profil/default.asp&PageAuth=yes&LogonType=ACCOUNT 4. when translation infobar show up, click "Translate" to translate to English 5. focus in "E-mail" field 6. press Down arrow 7. select the autofill data entry by double click on it 8. autofill data should be fill in all text boxes Review URL: http://codereview.chromium.org/5322001 TBR=dhollowa@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69090

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+84 lines, -227 lines)			Patch
M	chrome/browser/autofill/autofill_browsertest.cc	View	4 chunks	+81 lines, -212 lines	0 comments	Download
M	chrome/browser/autofill/autofill_manager.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 chunk	+0 lines, -9 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)