Issue 5682011: Add RunPylint as a canned presubmit check.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5682011: Add RunPylint as a canned presubmit check. (Closed)

Created:
10 years ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Add RunPylint as a canned presubmit check. Adding it as I figured out how to make it run correctly on ubuntu 10.4 and it's used in enough places it warrants a canned check. BUG=none TEST=it self tests itself. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69051

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed review comments #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+57 lines, -36 lines)			Patch
M	PRESUBMIT.py	View	1	2 chunks	+26 lines, -36 lines	0 comments	Download
M	presubmit_canned_checks.py	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download
M	tests/presubmit_unittest.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

10 years ago (2010-12-13 20:54:10 UTC) #2

LGTM

http://codereview.chromium.org/5682011/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

http://codereview.chromium.org/5682011/diff/1/PRESUBMIT.py#newcode31
PRESUBMIT.py:31: l = x.LocalPath()
Consider not using one-letter variable names here ("x", "l").

http://codereview.chromium.org/5682011/diff/1/presubmit_canned_checks.py
File presubmit_canned_checks.py (right):

http://codereview.chromium.org/5682011/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:457: # warnings messages.
typo: warning (no s)

http://codereview.chromium.org/5682011/diff/1/presubmit_canned_checks.py#newc...
presubmit_canned_checks.py:467: if source_file_filter(f)]
Do you know why this can't share code with the above arm of the try?

Expand Messages | Collapse Messages