net/base/bandwidth_metrics.cc - Issue 5682008: Make members of Singleton<T> private and only visible to the singleton type.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: net/base/bandwidth_metrics.cc

Issue 5682008: Make members of Singleton<T> private and only visible to the singleton type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/singleton.h"	5 #include "base/lazy_instance.h"

6 #include "net/base/bandwidth_metrics.h"	6 #include "net/base/bandwidth_metrics.h"

7	7

	8 static base::LazyInstance<net::BandwidthMetrics> g_bandwidth_metrics(

	9 base::LINKER_INITIALIZED);

	10

8 namespace net {	11 namespace net {

9	12

10 ScopedBandwidthMetrics::ScopedBandwidthMetrics()	13 ScopedBandwidthMetrics::ScopedBandwidthMetrics()

11 : metrics_(Singleton<BandwidthMetrics>::get()),	14 : metrics_(g_bandwidth_metrics.Pointer()),
	M-A Ruel 2010/12/10 14:52:18 I'm wondering about the usefulness of the metrics_ I'm wondering about the usefulness of the metrics_ variable at all. Unless it is used for mocking but I didn't see a unit test at first glance. Satish 2010/12/10 15:04:57 I'll move the implementation of this class's metho Show quoted text On 2010/12/10 14:52:18, Marc-Antoine Ruel wrote: > I'm wondering about the usefulness of the metrics_ variable at all. Unless it is > used for mocking but I didn't see a unit test at first glance. I'll move the implementation of this class's methods to this cc file and with that the metrics_ variable can be removed and g_bandwidth_metrics used instead. M-A Ruel 2010/12/10 15:09:42 Cool Show quoted text On 2010/12/10 15:04:57, Satish wrote: > On 2010/12/10 14:52:18, Marc-Antoine Ruel wrote: > > I'm wondering about the usefulness of the metrics_ variable at all. Unless it > is > > used for mocking but I didn't see a unit test at first glance. > > I'll move the implementation of this class's methods to this cc file and with > that the metrics_ variable can be removed and g_bandwidth_metrics used instead. Cool Satish 2010/12/10 17:13:48 Done. Show quoted text On 2010/12/10 15:04:57, Satish wrote: > On 2010/12/10 14:52:18, Marc-Antoine Ruel wrote: > > I'm wondering about the usefulness of the metrics_ variable at all. Unless it > is > > used for mocking but I didn't see a unit test at first glance. > > I'll move the implementation of this class's methods to this cc file and with > that the metrics_ variable can be removed and g_bandwidth_metrics used instead. Done.
12 started_(false) {	15 started_(false) {

13 }	16 }

14	17

15 } // namespace net	18 } // namespace net

OLD	NEW