Remove ICU header dependencies outside of /i18n directory....

Remove ICU header dependencies outside of /i18n directory.
BUG=49747
TEST=WordIteratorTest.*

[Tom Sepez, 2010-12-09 22:24:44]

Please review this first piece of these changes.  CDN to run a "try" for me.

[Evan Martin, 2010-12-09 22:29:10]

LGTM with suggestions for improved comments

http://codereview.chromium.org/5682002/diff/1/base/i18n/word_iterator.h
File base/i18n/word_iterator.h (right):

http://codereview.chromium.org/5682002/diff/1/base/i18n/word_iterator.h#newco...
base/i18n/word_iterator.h:25: // Under BREAK_LINE mode (less common), the
non-word character are
typo: character*s*

http://codereview.chromium.org/5682002/diff/1/base/i18n/word_iterator.h#newco...
base/i18n/word_iterator.h:27: // is encountered (eg. in the UTF16-equivalent of
the string " foo bar! ",
I think "UTF16-equivalent" is needless here, but your call.

http://codereview.chromium.org/5682002/diff/1/base/i18n/word_iterator.h#newco...
base/i18n/word_iterator.h:28: // the word breaks are  at the periods in ". .foo
.bar! .").
typo: double-space

http://codereview.chromium.org/5682002/diff/1/base/i18n/word_iterator.h#newco...
base/i18n/word_iterator.h:31: // through the string and test whether IsWord() is
true.  E.g.,
I hate to be pedantic but here we use "e.g." and above you use "eg.".

http://codereview.chromium.org/5682002/diff/1/base/i18n/word_iterator.h#newco...
base/i18n/word_iterator.h:80: // ICU iterator -- avoid ICU ubrk.h dependence.
Without this review for context, this comment line doesn't make sense.  Maybe
"ICU iterator, avoiding ICU ubrk.h dependence." would make it clearer.

[brettw, 2010-12-09 23:56:09]

LGTM with Evan's suggestions.

[Tom Sepez, 2010-12-10 01:13:29]

Updated comments in .h file.

CDN's "try" caught 1 windows build error.  Adding explicit dependence in
in_memory_url_index.cc on utypes.h that was formerly implicit via
word_iterator.h pulling ubrk.h pulling utypes.h.

[Cris Neckar, 2010-12-10 06:28:14]

LGTM

The try jobs all finished successfully so this should be gtg.

On 2010/12/10 01:13:29, Tom Sepez wrote:
> Updated comments in .h file.
> 
> CDN's "try" caught 1 windows build error.  Adding explicit dependence in
> in_memory_url_index.cc on utypes.h that was formerly implicit via
> word_iterator.h pulling ubrk.h pulling utypes.h.

[Cris Neckar, 2010-12-10 18:12:52]

This was committed as revision 68867

On 2010/12/10 06:28:14, cdn wrote:
> LGTM
> 
> The try jobs all finished successfully so this should be gtg.
> 
> On 2010/12/10 01:13:29, Tom Sepez wrote:
> > Updated comments in .h file.
> > 
> > CDN's "try" caught 1 windows build error.  Adding explicit dependence in
> > in_memory_url_index.cc on utypes.h that was formerly implicit via
> > word_iterator.h pulling ubrk.h pulling utypes.h.