Add support for ldrd/strd from Kun Zhang (zhangk@codeaurora.org), Code Aurora

src/arm/simulator-arm.cc

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 543 matching lines @@
 
 
 // Get the register from the architecture state. This function does handle
 // the special case of accessing the PC register.
 int32_t Simulator::get_register(int reg) const {
   ASSERT((reg >= 0) && (reg < num_registers));
   return registers_[reg] + ((reg == pc) ? Instr::kPCReadOffset : 0);
 }
 
 
+void Simulator::set_dw_register(int dreg, const int* dbl) {
+  ASSERT((dreg >= 0) && (dreg < num_d_registers));
+  registers_[dreg] = dbl[0];
+  registers_[dreg + 1] = dbl[1];
+}
+
+
 // Raw access to the PC register.
 void Simulator::set_pc(int32_t value) {
   pc_modified_ = true;
   registers_[pc] = value;
 }
 
 
 // Raw access to the PC register without the special adjustment when reading.
 int32_t Simulator::get_pc() const {
   return registers_[pc];
@@ skipping 215 matching lines @@
   *ptr = value;
 }
 
 
 void Simulator::WriteB(int32_t addr, int8_t value) {
   int8_t* ptr = reinterpret_cast<int8_t*>(addr);
   *ptr = value;
 }
 
 
+int* Simulator::ReadDW(int32_t addr) {

[Erik Corry, 2010/05/04 07:06:13]

Please use int32_t for things like this where the size is given by the CPU spec.

[zhangk, 2010/05/07 05:32:14]

On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

+  int *ptr = reinterpret_cast<int *>(addr);

[Erik Corry, 2010/05/04 07:06:13]

int *ptr -> int* ptr

[zhangk, 2010/05/07 05:32:14]

On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

+  return ptr;
+}
+
+
+void Simulator::WriteDW(int32_t addr, int32_t value1, int32_t value2) {
+  int32_t *ptr = reinterpret_cast<int32_t*>(addr);

[Erik Corry, 2010/05/04 07:06:13]

Asterisk placement.

[zhangk, 2010/05/07 05:32:14]

On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

+  *ptr++ = value1;
+  *ptr = value2;
+  return;
+}
+
+
 // Returns the limit of the stack area to enable checking for stack overflows.
 uintptr_t Simulator::StackLimit() const {
   // Leave a safety margin of 256 bytes to prevent overrunning the stack when
   // pushing values.
   return reinterpret_cast<uintptr_t>(stack_) + 256;
 }
 
 
 // Unsupported instructions use Format to print an error and stop execution.
 void Simulator::Format(Instr* instr, const char* format) {
@@ skipping 592 matching lines @@
             }
             break;
           }
           default: {
             // The PU field is a 2-bit field.
             UNREACHABLE();
             break;
           }
         }
       }
-      if (instr->HasH()) {
+      if (((instr->Bits(7, 4) & 0xd) == 0xd) && (instr->Bit(20) == 0)) {
+        if (instr->HasH()) {
+          // strd

[Erik Corry, 2010/05/04 07:06:13]

Please check that rd specifies an even-numbered register.

[zhangk, 2010/05/07 05:32:14]

On 2010/05/04 07:06:13, Erik Corry wrote:

Done.

+          int32_t value1 = get_register(rd);
+          int32_t value2 = get_register(rd+1);
+          WriteDW(addr, value1, value2);
+        } else {
+          // ldrd
+          int* rn_data = ReadDW(addr);
+          set_dw_register(rd, rn_data);
+        }
+      } else if (instr->HasH()) {
         if (instr->HasSign()) {
           if (instr->HasL()) {
             int16_t val = ReadH(addr, instr);
             set_register(rd, val);
           } else {
             int16_t val = get_register(rd);
             WriteH(addr, val, instr);
           }
         } else {
           if (instr->HasL()) {
@@ skipping 864 matching lines @@
   uintptr_t* stack_slot = reinterpret_cast<uintptr_t*>(current_sp);
   uintptr_t address = *stack_slot;
   set_register(sp, current_sp + sizeof(uintptr_t));
   return address;
 }
 
 
 } }  // namespace assembler::arm
 
 #endif  // !defined(__arm__)