Issue 5680007: Make IndexedDBDispatcherHost be a message filter and move its messages into a...

Issue 5680007: Make IndexedDBDispatcherHost be a message filter and move its messages into a... (Closed)

Created:
10 years ago by jam

Modified:
9 years, 7 months ago

Reviewers:
jorlow

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Make IndexedDBDispatcherHost be a message filter and move its messages into a separate file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69050

Patch Set 4 : '' #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1305 lines, -1514 lines)			Patch
M	chrome/browser/in_process_webkit/indexed_db_callbacks.h	View	1 2 3	6 chunks	+11 lines, -12 lines	0 comments	Download
M	chrome/browser/in_process_webkit/indexed_db_callbacks.cc	View	1 2 3	1 chunk	+4 lines, -4 lines	0 comments	Download
M	chrome/browser/in_process_webkit/indexed_db_dispatcher_host.h	View	1 2 3	10 chunks	+67 lines, -76 lines	0 comments	Download
M	chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc	View	1 2 3	27 chunks	+263 lines, -473 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	1 2 3	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.h	View	1 2 3	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/renderer_host/resource_message_filter.cc	View	1 2 3	5 chunks	+1 line, -9 lines	0 comments	Download
M	chrome/chrome_common.gypi	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
A	chrome/common/indexed_db_messages.h	View	1 2 3	1 chunk	+493 lines, -0 lines	0 comments	Download
A	chrome/common/indexed_db_messages.cc	View		1 chunk	+339 lines, -0 lines	0 comments	Download
M	chrome/common/render_messages.h	View	1 2 3	2 chunks	+0 lines, -7 lines	0 comments	Download
M	chrome/common/render_messages.cc	View	1 2 3	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 2 3	4 chunks	+0 lines, -274 lines	0 comments	Download
M	chrome/common/render_messages_params.h	View	1 2 3	3 chunks	+0 lines, -196 lines	0 comments	Download
M	chrome/common/render_messages_params.cc	View	1 2 3	3 chunks	+0 lines, -325 lines	0 comments	Download
M	chrome/renderer/indexed_db_dispatcher.cc	View	1 2 3	15 chunks	+71 lines, -78 lines	0 comments	Download
M	chrome/renderer/renderer_webidbcursor_impl.cc	View	1 2 3	3 chunks	+6 lines, -8 lines	0 comments	Download
M	chrome/renderer/renderer_webidbdatabase_impl.cc	View	1 2 3	5 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/renderer/renderer_webidbindex_impl.cc	View	1 2 3	2 chunks	+8 lines, -7 lines	0 comments	Download
M	chrome/renderer/renderer_webidbobjectstore_impl.cc	View	1 2 3	5 chunks	+16 lines, -17 lines	0 comments	Download
M	chrome/renderer/renderer_webidbtransaction_impl.cc	View	1 2 3	4 chunks	+6 lines, -6 lines	0 comments	Download
M	ipc/ipc_message_utils.h	View	1 2 3	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jorlow

LGTM Thanks for doing all of this refactoring! http://codereview.chromium.org/5680007/diff/23003/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right): http://codereview.chromium.org/5680007/diff/23003/chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc#newcode111 chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:111: bool ...

10 years ago (2010-12-13 18:24:04 UTC) #2

jam

10 years ago (2010-12-13 20:41:05 UTC) #3

http://codereview.chromium.org/5680007/diff/23003/chrome/browser/in_process_w...
File chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc (right):

http://codereview.chromium.org/5680007/diff/23003/chrome/browser/in_process_w...
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:111: bool
msg_is_ok = true;
On 2010/12/13 18:24:04, jorlow wrote:
> What if it's not OK?

oops, this was unused, removed

http://codereview.chromium.org/5680007/diff/23003/chrome/browser/in_process_w...
chrome/browser/in_process_webkit/indexed_db_dispatcher_host.cc:115:
object_store_dispatcher_host_->OnMessageReceived(message, message_was_ok) ||
On 2010/12/13 18:24:04, jorlow wrote:
> >80

Done.

http://codereview.chromium.org/5680007/diff/23003/chrome/browser/renderer_hos...
File chrome/browser/renderer_host/browser_render_process_host.cc (right):

http://codereview.chromium.org/5680007/diff/23003/chrome/browser/renderer_hos...
chrome/browser/renderer_host/browser_render_process_host.cc:392:
channel_->AddFilter(new IndexedDBDispatcherHost(id(), profile()));
On 2010/12/13 18:24:04, jorlow wrote:
> bad indent

Done.

Expand Messages | Collapse Messages