Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 5680006: Add support for an --upstream_branch argument to make diffing against... (Closed)

Created:
10 years ago by Dirk Pranke
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Add support for an --upstream_branch argument to make diffing against things other than trunk easier. BUG=none R=maruel@chromium.org TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69307

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M trychange.py View 2 chunks +7 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Dirk Pranke
Ping ... Marc-Antoine, what do you think about this?
10 years ago (2010-12-15 19:56:26 UTC) #1
M-A Ruel
10 years ago (2010-12-15 20:01:21 UTC) #2
lgtm

(you didn't send an email either for this one)

http://codereview.chromium.org/5680006/diff/1/trychange.py
File trychange.py (right):

http://codereview.chromium.org/5680006/diff/1/trychange.py#newcode579
trychange.py:579: "main checkout")
can you align with the = ?

Powered by Google App Engine
This is Rietveld 408576698