Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 5678006: Check in a quick sed script to reduce Mac build logs. (Closed)

Created:
10 years ago by Evan Martin
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai, evanm
CC:
chromium-reviews
Visibility:
Public.

Description

Check in a quick sed script to reduce Mac build logs. This strips out most of the command lines, making it look a little more like the Linux output. TEST=download mac build output; ./build/sanitize-mac-build-log.sed < build-output and verify it is shorter Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69027

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixes #

Patch Set 3 : wip #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
A build/sanitize-mac-build-log.sed View 1 1 chunk +18 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
Mark Mentovai
http://codereview.chromium.org/5678006/diff/1/build/sanitize-mac-build-log.sed File build/sanitize-mac-build-log.sed (right): http://codereview.chromium.org/5678006/diff/1/build/sanitize-mac-build-log.sed#newcode14 build/sanitize-mac-build-log.sed:14: \|^ /Developer/usr/bin/g++|d I think Xcode always invokes gcc (with ...
10 years ago (2010-12-10 22:36:18 UTC) #1
evanm
On 2010/12/10 22:36:18, Mark Mentovai wrote: > http://codereview.chromium.org/5678006/diff/1/build/sanitize-mac-build-log.sed#newcode14 > build/sanitize-mac-build-log.sed:14: \|^ /Developer/usr/bin/g++|d > I think ...
10 years ago (2010-12-10 22:51:24 UTC) #2
Mark Mentovai
Evan wrote: > I guess if you're building locally, Xcode knows how to trim this ...
10 years ago (2010-12-10 22:54:07 UTC) #3
Evan Martin
My last mail was intended to indicate PTAL but it wasn't clear. So: PTAL
10 years ago (2010-12-13 18:50:58 UTC) #4
Mark Mentovai
10 years ago (2010-12-13 18:54:13 UTC) #5
LGTM

http://codereview.chromium.org/5678006/diff/3002/build/sanitize-mac-build-log...
File build/sanitize-mac-build-log.sed (right):

http://codereview.chromium.org/5678006/diff/3002/build/sanitize-mac-build-log...
build/sanitize-mac-build-log.sed:2: 
Give me some stupid boilerplate lice.

Also, make sure the file gets checked in with the proper svn:eol-style.

Powered by Google App Engine
This is Rietveld 408576698