Issue 5678003: Merge 68104 - [ChromeOS] Make GaiaAutheFetcher parsing logic default to servi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5678003: Merge 68104 - [ChromeOS] Make GaiaAutheFetcher parsing logic default to servi... (Closed)

Created:
10 years ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
Chris Masone

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/branches/597/src/

Visibility:
Public.

Description

Merge 68104 - [ChromeOS] Make GaiaAutheFetcher parsing logic default to service_unavailable The logic that parses responses from Google Accounts servers was defaulting to INVALID_GAIA_CREDENTIALS, which indicate a successful communication with teh backend that resulted in a failing authentication attempt. Gibberish was thus interpreted this way. We should instead interpret gibberish as an unsuccessful communication attempt. BUG=chromium-os:8943 TEST=unit tests, installed on device and ran successful login and failed login autotests. Also tried live login. Review URL: http://codereview.chromium.org/5309007 TBR=cmasone@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68763

Patch Set 1 #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -2 lines)			Patch
M	chrome/common/net/gaia/gaia_auth_fetcher.h	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	chrome/common/net/gaia/gaia_auth_fetcher.cc	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/common/net/gaia/gaia_auth_fetcher_unittest.cc	View	2 chunks	+17 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages