Verify that previously saved username/password shows up in Regular Window, NT...

Verify that previously saved username/password shows up in Regular Window, NTP and incognito window.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=69046

[Nirnimesh, 2010-12-10 09:20:01]

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py#newcode85
functional/passwords.py:85: def testFormValues(win_index, tab_index):
Do not prefix with 'test'
How about: VerifyFormValues?

Or maybe you could use test_utils.VerifyGoogleAccountCredsFilled() like used
above

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py#newcode87
functional/passwords.py:87: win_index, tab_index)
indent by 4 spaces

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py#newcode87
functional/passwords.py:87: win_index, tab_index)
pass named args for windex, tab_index

[ismail, 2010-12-10 22:44:27]

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py#newcode85
functional/passwords.py:85: def testFormValues(win_index, tab_index):
On 2010/12/10 09:20:01, Nirnimesh wrote:
> Do not prefix with 'test'
> How about: VerifyFormValues?
> 
> Or maybe you could use test_utils.VerifyGoogleAccountCredsFilled() like used
> above

Done.

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py#newcode87
functional/passwords.py:87: win_index, tab_index)
On 2010/12/10 09:20:01, Nirnimesh wrote:
> indent by 4 spaces

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py#newcode87
functional/passwords.py:87: win_index, tab_index)
On 2010/12/10 09:20:01, Nirnimesh wrote:
> indent by 4 spaces

Done.

http://codereview.chromium.org/5675001/diff/1/functional/passwords.py#newcode87
functional/passwords.py:87: win_index, tab_index)
On 2010/12/10 09:20:01, Nirnimesh wrote:
> pass named args for windex, tab_index

Done.

[Nirnimesh, 2010-12-10 22:50:07]

http://codereview.chromium.org/5675001/diff/5001/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/5675001/diff/5001/functional/passwords.py#newc...
functional/passwords.py:90: test_utils.VerifyGoogleAccountCredsFilled(self,
username, password)
this and line 93 still just checks in first tab/first window.
Sunand is updating VerifyGoogleAccountCredsFilled to take tab_index and windex
params in http://codereview.chromium.org/5379007

Please update accordingly.

[ismail, 2010-12-11 02:03:36]

http://codereview.chromium.org/5675001/diff/5001/functional/passwords.py
File functional/passwords.py (right):

http://codereview.chromium.org/5675001/diff/5001/functional/passwords.py#newc...
functional/passwords.py:90: test_utils.VerifyGoogleAccountCredsFilled(self,
username, password)
On 2010/12/10 22:50:08, Nirnimesh wrote:
> this and line 93 still just checks in first tab/first window.
> Sunand is updating VerifyGoogleAccountCredsFilled to take tab_index and windex
> params in http://codereview.chromium.org/5379007
> 
> Please update accordingly.

Done.

[Nirnimesh, 2010-12-11 02:04:35]

LGTM.