chrome/browser/chromeos/proxy_config_service_impl.h - Issue 5671003: [Chrome OS] Plumb new error codes from SignedSettings to consumers of the API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/proxy_config_service_impl.h

Issue 5671003: [Chrome OS] Plumb new error codes from SignedSettings to consumers of the API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: remove untoward log statement Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/signed_settings_unittest.cc ('k') | chrome/browser/chromeos/proxy_config_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/proxy_config_service_impl.h

diff --git a/chrome/browser/chromeos/proxy_config_service_impl.h b/chrome/browser/chromeos/proxy_config_service_impl.h

index 8c42bd775011ddf136380b53e70226ae8f74b48f..2e605a86640814993014193134177cd308381faf 100644

--- a/chrome/browser/chromeos/proxy_config_service_impl.h

+++ b/chrome/browser/chromeos/proxy_config_service_impl.h

@@ -190,9 +190,10 @@ class ProxyConfigServiceImpl

bool UISetProxyConfigBypassRules(const net::ProxyBypassRules& bypass_rules);

// Implementation for SignedSettings::Delegate

- virtual void OnSettingsOpSucceeded(bool value);

- virtual void OnSettingsOpSucceeded(std::string value);

- virtual void OnSettingsOpFailed(SignedSettings::FailureCode code);

+ virtual void OnSettingsOpCompleted(SignedSettings::ReturnCode code,

+ std::string value);

+ virtual void OnSettingsOpCompleted(SignedSettings::ReturnCode code,

+ bool value);

private:

friend class base::RefCountedThreadSafe<ProxyConfigServiceImpl>;

« no previous file with comments | « chrome/browser/chromeos/login/signed_settings_unittest.cc ('k') | chrome/browser/chromeos/proxy_config_service_impl.cc » ('j') | no next file with comments »