Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Unified Diff: chrome/browser/chromeos/login/signed_settings_helper.h

Issue 5671003: [Chrome OS] Plumb new error codes from SignedSettings to consumers of the API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove untoward log statement Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/signed_settings_helper.h
diff --git a/chrome/browser/chromeos/login/signed_settings_helper.h b/chrome/browser/chromeos/login/signed_settings_helper.h
index cfe99e480a1fd10f23207a3f0963f62d53efbfb7..d65b6778f47130328e605074dc5ac6839777552c 100644
--- a/chrome/browser/chromeos/login/signed_settings_helper.h
+++ b/chrome/browser/chromeos/login/signed_settings_helper.h
@@ -6,7 +6,7 @@
#define CHROME_BROWSER_CHROMEOS_LOGIN_SIGNED_SETTINGS_HELPER_H_
#pragma once
-#include <string>
+#include "chrome/browser/chromeos/login/signed_settings.h"
namespace chromeos {
@@ -20,24 +20,29 @@ class SignedSettingsHelper {
public:
// Callback of CheckWhitelistOp. |success| indicates whether the op succeeds
// or not. |email| is the email that is checked against.
- virtual void OnCheckWhiteListCompleted(
- bool success, const std::string& email) {}
+ virtual void OnCheckWhitelistCompleted(
+ SignedSettings::ReturnCode code,
+ const std::string& email) {}
// Callback of WhitelistOp that adds |email| to the whitelist.
virtual void OnWhitelistCompleted(
- bool success, const std::string& email) {}
+ SignedSettings::ReturnCode code, const std::string& email) {}
// Callback of WhitelistOp that removes |email| to the whitelist.
virtual void OnUnwhitelistCompleted(
- bool success, const std::string& email) {}
+ SignedSettings::ReturnCode code, const std::string& email) {}
// Callback of StorePropertyOp.
virtual void OnStorePropertyCompleted(
- bool success, const std::string& name, const std::string& value) {}
+ SignedSettings::ReturnCode code,
+ const std::string& name,
+ const std::string& value) {}
// Callback of RetrievePropertyOp.
virtual void OnRetrievePropertyCompleted(
- bool success, const std::string& name, const std::string& value) {}
+ SignedSettings::ReturnCode code,
+ const std::string& name,
+ const std::string& value) {}
};
// Class factory
« no previous file with comments | « chrome/browser/chromeos/login/signed_settings.cc ('k') | chrome/browser/chromeos/login/signed_settings_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698