Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: chrome/browser/chromeos/login/signed_settings.h

Issue 5671003: [Chrome OS] Plumb new error codes from SignedSettings to consumers of the API (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: remove untoward log statement Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/login/login_performer.cc ('k') | chrome/browser/chromeos/login/signed_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/login/signed_settings.h
diff --git a/chrome/browser/chromeos/login/signed_settings.h b/chrome/browser/chromeos/login/signed_settings.h
index 69f2bd0ae347e2cd6e2bff87e4dbede84e8d99c4..61d5e15805e6571087bcd862f224fef37a676de4 100644
--- a/chrome/browser/chromeos/login/signed_settings.h
+++ b/chrome/browser/chromeos/login/signed_settings.h
@@ -35,7 +35,8 @@ class OwnershipService;
class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
public OwnerManager::Delegate {
public:
- enum FailureCode {
+ enum ReturnCode {
+ SUCCESS,
NOT_FOUND, // Email address or property name not found.
KEY_UNAVAILABLE, // Owner key not yet configured.
OPERATION_FAILED // Signature op or IPC to signed settings daemon failed.
@@ -44,9 +45,8 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
template <class T>
class Delegate {
public:
- // These methods will be called on the UI thread.
- virtual void OnSettingsOpSucceeded(T value) {}
- virtual void OnSettingsOpFailed(FailureCode code) {}
+ // This method will be called on the UI thread.
+ virtual void OnSettingsOpCompleted(ReturnCode code, T value) {}
};
SignedSettings();
@@ -73,7 +73,7 @@ class SignedSettings : public base::RefCountedThreadSafe<SignedSettings>,
const std::string& name,
SignedSettings::Delegate<std::string>* d);
- static FailureCode MapKeyOpCode(OwnerManager::KeyOpCode code);
+ static ReturnCode MapKeyOpCode(OwnerManager::KeyOpCode code);
virtual void Execute() = 0;
« no previous file with comments | « chrome/browser/chromeos/login/login_performer.cc ('k') | chrome/browser/chromeos/login/signed_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698