[Chrome OS] Plumb new error codes from SignedSettings to consumers of the API

chrome/browser/chromeos/user_cros_settings_provider.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/user_cros_settings_provider.h"
 
 #include <map>
 #include <set>
 
 #include "base/hash_tables.h"
@@ skipping 287 matching lines @@
       return;
     // Do not trust before fetching complete.
     prefs->ClearPref((name + kTrustedSuffix).c_str());
     prefs->ScheduleSavePersistentPrefs();
     if (CrosLibrary::Get()->EnsureLoaded()) {
       SignedSettingsHelper::Get()->StartRetrieveProperty(name, this);
     }
   }
 
   // Implementation of SignedSettingsHelper::Callback.
-  virtual void OnRetrievePropertyCompleted(bool success,
+  virtual void OnRetrievePropertyCompleted(SignedSettings::ReturnCode code,
                                            const std::string& name,
                                            const std::string& value) {
     if (!IsControlledBooleanSetting(name) && !IsControlledStringSetting(name)) {
       NOTREACHED();
       return;
     }
     DCHECK(GetOwnershipStatus() != OWNERSHIP_UNKNOWN);
 
+    bool success = code == SignedSettings::SUCCESS;
     PrefService* prefs = g_browser_process->local_state();
     if (!success && GetOwnershipStatus() == OWNERSHIP_TAKEN) {
       LOG(ERROR) << "On owned device: failed to retrieve cros "
                     "setting, name=" << name;
       if (retries_left_ > 0) {
         retries_left_ -= 1;
         StartFetchingSetting(name);
         return;
       }
       LOG(ERROR) << "No retries left";
@@ skipping 32 matching lines @@
       std::vector<Task*>& callbacks_vector = callbacks_[name];
       for (size_t i = 0; i < callbacks_vector.size(); ++i)
         MessageLoop::current()->PostTask(FROM_HERE, callbacks_vector[i]);
       callbacks_vector.clear();
     }
     if (success)
       CrosSettings::Get()->FireObservers(name.c_str());
   }
 
   // Implementation of SignedSettingsHelper::Callback.
-  virtual void OnStorePropertyCompleted(bool success,
+  virtual void OnStorePropertyCompleted(SignedSettings::ReturnCode code,
                                         const std::string& name,
                                         const std::string& value) {
-    VLOG(1) << "Store cros setting " << name << "=" << value << ", success="
-            << success;
+    VLOG(1) << "Store cros setting " << name << "=" << value << ", code="
+            << code;
 
     // Reload the setting if store op fails.
-    if (!success)
+    if (code != SignedSettings::SUCCESS)
       SignedSettingsHelper::Get()->StartRetrieveProperty(name, this);
   }
 
   // Implementation of SignedSettingsHelper::Callback.
-  virtual void OnWhitelistCompleted(bool success, const std::string& email) {
-    VLOG(1) << "Add " << email << " to whitelist, success=" << success;
+  virtual void OnWhitelistCompleted(SignedSettings::ReturnCode code,
+                                    const std::string& email) {
+    VLOG(1) << "Add " << email << " to whitelist, code=" << code;
 
     // Reload the whitelist on settings op failure.
-    if (!success)
+    if (code != SignedSettings::SUCCESS)
       CrosSettings::Get()->FireObservers(kAccountsPrefUsers);
   }
 
   // Implementation of SignedSettingsHelper::Callback.
-  virtual void OnUnwhitelistCompleted(bool success, const std::string& email) {
-    VLOG(1) << "Remove " << email << " from whitelist, success=" << success;
+  virtual void OnUnwhitelistCompleted(SignedSettings::ReturnCode code,
+                                      const std::string& email) {
+    VLOG(1) << "Remove " << email << " from whitelist, code=" << code;
 
     // Reload the whitelist on settings op failure.
-    if (!success)
+    if (code != SignedSettings::SUCCESS)
       CrosSettings::Get()->FireObservers(kAccountsPrefUsers);
   }
 
   // NotificationObserver implementation.
   virtual void Observe(NotificationType type,
                        const NotificationSource& source,
                        const NotificationDetails& details) {
     if (type.value == NotificationType::OWNERSHIP_TAKEN) {
       SetOwnershipStatus(OWNERSHIP_TAKEN, SOURCE_OBSERVE);
       notification_registrar_.RemoveAll();
@@ skipping 147 matching lines @@
   return false;
 }
 
 bool UserCrosSettingsProvider::HandlesSetting(const std::string& path) {
   return ::StartsWithASCII(path, "cros.accounts.", true);
 }
 
 void UserCrosSettingsProvider::WhitelistUser(const std::string& email) {
   SignedSettingsHelper::Get()->StartWhitelistOp(
       email, true, UserCrosSettingsTrust::GetSharedInstance());
-
   PrefService* prefs = g_browser_process->local_state();
   ListValue* cached_whitelist = prefs->GetMutableList(kAccountsPrefUsers);
   cached_whitelist->Append(Value::CreateStringValue(email));
   prefs->ScheduleSavePersistentPrefs();
 }
 
 void UserCrosSettingsProvider::UnwhitelistUser(const std::string& email) {
   SignedSettingsHelper::Get()->StartWhitelistOp(
       email, false, UserCrosSettingsTrust::GetSharedInstance());
 
   PrefService* prefs = g_browser_process->local_state();
   ListValue* cached_whitelist = prefs->GetMutableList(kAccountsPrefUsers);
   StringValue email_value(email);
   if (cached_whitelist->Remove(email_value) != -1)
     prefs->ScheduleSavePersistentPrefs();
 }
 
 // static
 void UserCrosSettingsProvider::UpdateCachedOwner(const std::string& email) {
   UpdateCacheString(kDeviceOwner, email, USE_VALUE_SUPPLIED);
 }
 
 }  // namespace chromeos