[Chrome OS] Plumb new error codes from SignedSettings to consumers of the API

chrome/browser/chromeos/login/signed_settings_helper_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/signed_settings_helper.h"
 
 #include "chrome/browser/browser_thread.h"
 #include "chrome/browser/chromeos/cros/cros_library.h"
 #include "chrome/browser/chromeos/login/mock_ownership_service.h"
 #include "chrome/browser/chromeos/login/owner_manager.h"
 #include "chrome/browser/chromeos/login/signed_settings.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using ::testing::_;
 using ::testing::InSequence;
 
 namespace chromeos {
 
 class MockSignedSettingsHelperCallback : public SignedSettingsHelper::Callback {
  public:
-  MOCK_METHOD2(OnCheckWhiteListCompleted, void(
-      bool success, const std::string& email));
+  MOCK_METHOD2(OnCheckWhitelistCompleted, void(
+      SignedSettings::ReturnCode code, const std::string& email));
   MOCK_METHOD2(OnWhitelistCompleted, void(
-      bool success, const std::string& email));
+      SignedSettings::ReturnCode code, const std::string& email));
   MOCK_METHOD2(OnUnwhitelistCompleted, void(
-      bool success, const std::string& email));
+      SignedSettings::ReturnCode code, const std::string& email));
   MOCK_METHOD3(OnStorePropertyCompleted, void(
-      bool success, const std::string& name, const std::string& value));
+      SignedSettings::ReturnCode code,
+      const std::string& name,
+      const std::string& value));
   MOCK_METHOD3(OnRetrievePropertyCompleted, void(
-      bool success, const std::string& name, const std::string& value));
+      SignedSettings::ReturnCode code,
+      const std::string& name,
+      const std::string& value));
 };
 
 class SignedSettingsHelperTest : public ::testing::Test,
                                  public SignedSettingsHelper::TestDelegate {
  public:
   SignedSettingsHelperTest()
       : fake_email_("fakey"),
         fake_prop_("prop_name"),
         fake_value_("stub"),
         message_loop_(MessageLoop::TYPE_UI),
@@ skipping 39 matching lines @@
 
   ScopedStubCrosEnabler stub_cros_enabler_;
 };
 
 TEST_F(SignedSettingsHelperTest, SerializedOps) {
   MockSignedSettingsHelperCallback cb;
 
   EXPECT_CALL(m_, IsAlreadyOwned()).Times(2);
   InSequence s;
   EXPECT_CALL(m_, StartVerifyAttempt(_, _, _)).Times(1);
-  EXPECT_CALL(cb, OnCheckWhiteListCompleted(true, _))
+  EXPECT_CALL(cb, OnCheckWhitelistCompleted(SignedSettings::SUCCESS, _))
       .Times(1);
   EXPECT_CALL(m_, StartSigningAttempt(_, _)).Times(1);
-  EXPECT_CALL(cb, OnWhitelistCompleted(true, _))
+  EXPECT_CALL(cb, OnWhitelistCompleted(SignedSettings::SUCCESS, _))
       .Times(1);
   EXPECT_CALL(m_, StartSigningAttempt(_, _)).Times(1);
-  EXPECT_CALL(cb, OnUnwhitelistCompleted(true, _))
+  EXPECT_CALL(cb, OnUnwhitelistCompleted(SignedSettings::SUCCESS, _))
       .Times(1);
   EXPECT_CALL(m_, StartSigningAttempt(_, _)).Times(1);
-  EXPECT_CALL(cb, OnStorePropertyCompleted(true, _, _))
+  EXPECT_CALL(cb, OnStorePropertyCompleted(SignedSettings::SUCCESS, _, _))
       .Times(1);
   EXPECT_CALL(m_, StartVerifyAttempt(_, _, _)).Times(1);
-  EXPECT_CALL(cb, OnRetrievePropertyCompleted(true, _, _))
+  EXPECT_CALL(cb, OnRetrievePropertyCompleted(SignedSettings::SUCCESS, _, _))
       .Times(1);
 
   pending_ops_ = 5;
   SignedSettingsHelper::Get()->StartCheckWhitelistOp(fake_email_, &cb);
   SignedSettingsHelper::Get()->StartWhitelistOp(fake_email_, true, &cb);
   SignedSettingsHelper::Get()->StartWhitelistOp(fake_email_, false, &cb);
   SignedSettingsHelper::Get()->StartStorePropertyOp(fake_prop_, fake_value_,
       &cb);
   SignedSettingsHelper::Get()->StartRetrieveProperty(fake_prop_, &cb);
 
   message_loop_.Run();
 }
 
 TEST_F(SignedSettingsHelperTest, CanceledOps) {
   MockSignedSettingsHelperCallback cb;
 
   EXPECT_CALL(m_, IsAlreadyOwned()).Times(2);
   InSequence s;
   EXPECT_CALL(m_, StartVerifyAttempt(_, _, _)).Times(1);
-  EXPECT_CALL(cb, OnCheckWhiteListCompleted(true, _))
+  EXPECT_CALL(cb, OnCheckWhitelistCompleted(SignedSettings::SUCCESS, _))
       .Times(1);
   EXPECT_CALL(m_, StartSigningAttempt(_, _)).Times(1);
-  EXPECT_CALL(cb, OnWhitelistCompleted(true, _))
+  EXPECT_CALL(cb, OnWhitelistCompleted(SignedSettings::SUCCESS, _))
       .Times(1);
   EXPECT_CALL(m_, StartSigningAttempt(_, _)).Times(1);
-  EXPECT_CALL(cb, OnUnwhitelistCompleted(true, _))
+  EXPECT_CALL(cb, OnUnwhitelistCompleted(SignedSettings::SUCCESS, _))
       .Times(1);
 
   // CheckWhitelistOp for cb_to_be_canceled still gets executed but callback
   // does not happen.
   EXPECT_CALL(m_, StartVerifyAttempt(_, _, _)).Times(1);
 
   EXPECT_CALL(m_, StartSigningAttempt(_, _)).Times(1);
-  EXPECT_CALL(cb, OnStorePropertyCompleted(true, _, _))
+  EXPECT_CALL(cb, OnStorePropertyCompleted(SignedSettings::SUCCESS, _, _))
       .Times(1);
   EXPECT_CALL(m_, StartVerifyAttempt(_, _, _)).Times(1);
-  EXPECT_CALL(cb, OnRetrievePropertyCompleted(true, _, _))
+  EXPECT_CALL(cb, OnRetrievePropertyCompleted(SignedSettings::SUCCESS, _, _))
       .Times(1);
 
   pending_ops_ = 6;
   SignedSettingsHelper::Get()->StartCheckWhitelistOp(fake_email_, &cb);
   SignedSettingsHelper::Get()->StartWhitelistOp(fake_email_, true, &cb);
   SignedSettingsHelper::Get()->StartWhitelistOp(fake_email_, false, &cb);
 
   MockSignedSettingsHelperCallback cb_to_be_canceled;
   SignedSettingsHelper::Get()->StartCheckWhitelistOp(fake_email_,
       &cb_to_be_canceled);
   SignedSettingsHelper::Get()->CancelCallback(&cb_to_be_canceled);
 
   SignedSettingsHelper::Get()->StartStorePropertyOp(fake_prop_, fake_value_,
       &cb);
   SignedSettingsHelper::Get()->StartRetrieveProperty(fake_prop_, &cb);
 
   message_loop_.Run();
 }
 
 }  // namespace chromeos