src/runtime.cc - Issue 567011: Fix a bug that Math.round() returns incorrect results for huge integers.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 567011: Fix a bug that Math.round() returns incorrect results for huge integers. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: '' Created 10 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

===================================================================

--- src/runtime.cc (revision 3760)

+++ src/runtime.cc (working copy)

@@ -4662,7 +4662,8 @@

CONVERT_DOUBLE_CHECKED(x, args[0]);

if (signbit(x) && x >= -0.5) return Heap::minus_zero_value();

- return Heap::NumberFromDouble(floor(x + 0.5));

+ double integer = ceil(x);

+ return Heap::NumberFromDouble(integer - x > 0.5 ? integer - 1.0 : integer);

}

« no previous file with comments | « no previous file | test/mjsunit/math-round.js » ('j') | no next file with comments »