|
Merge 73531 - https://bugs.webkit.org/show_bug.cgi?id=50576
Reviewed by Anders Carlsson.
REGRESSION in position of autocomplete popup on RTL page.
RTL static position computation did not subtract out the width of the enclosing box if the
immediate parent was a RenderInline. This bug was exposed by properly changing the RenderView
to be RTL when the document was RTL.
Added three new tests in fast/block/positioning.
WebCore:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidth):
LayoutTests:
* fast/block/positioning/rtl-static-positioning-inline-block.html: Added.
* fast/block/positioning/rtl-static-positioning.html: Added.
* fast/block/positioning/table-cell-static-position.html: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.png: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png: Added.
* platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.png: Added.
* platform/mac/fast/block/positioning/table-cell-static-position-expected.txt: Added.
TBR=jamesr@chromium.org
BUG= 62451
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=73556
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+40 lines, --3 lines) |
Patch |
![](/static/closedtriangle.gif) |
M |
LayoutTests/ChangeLog
|
View
|
|
1 chunk |
+27 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/fast/block/positioning/rtl-static-positioning.html
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/fast/block/positioning/rtl-static-positioning-inline-block.html
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/fast/block/positioning/table-cell-static-position.html
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-expected.checksum
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-expected.png
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.checksum
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.png
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/rtl-static-positioning-inline-block-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/table-cell-static-position-expected.checksum
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/table-cell-static-position-expected.png
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
A + |
LayoutTests/platform/mac/fast/block/positioning/table-cell-static-position-expected.txt
|
View
|
|
0 chunks |
+-1 lines, --1 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
WebCore/ChangeLog
|
View
|
|
1 chunk |
+17 lines, -0 lines |
0 comments
|
Download
|
![](/static/closedtriangle.gif) |
M |
WebCore/rendering/RenderBox.cpp
|
View
|
|
1 chunk |
+8 lines, -9 lines |
0 comments
|
Download
|
Total messages: 1 (0 generated)
|