Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 5663: Small cleanup of the code generator: make the static code gen... (Closed)

Created:
12 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Small cleanup of the code generator: make the static code gen functions and the ones defined on the AST nodes take a code generator, rather than a macro assembler and (sometimes) scope. Uniformly use the __ macro for masm_/masm in the codegen*.cc files. Committed: http://code.google.com/p/v8/source/detail?r=408

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -164 lines) Patch
M src/ast.h View 4 chunks +4 lines, -8 lines 0 comments Download
M src/codegen.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codegen-arm.cc View 22 chunks +78 lines, -60 lines 1 comment Download
M src/codegen-ia32.cc View 28 chunks +100 lines, -96 lines 1 comment Download

Messages

Total messages: 1 (0 generated)
Kasper Lund
12 years, 2 months ago (2008-10-02 08:57:58 UTC) #1
We still need to move the __ definitions around so we don't define and undef
them all over the place. We should also work towards a good solution for the
virtual scope() function in CodeGenerator; ideally we should pass something
around that would allow us to call the platform-specific functions in an easy
way without having to add a lot of virtual functions to CodeGenerator.

LGTM.

http://codereview.chromium.org/5663/diff/1/4
File src/codegen-arm.cc (right):

http://codereview.chromium.org/5663/diff/1/4#newcode2062
Line 2062: masm->pop(r0);  // value
Shouldn't this be __?

http://codereview.chromium.org/5663/diff/1/5
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/5663/diff/1/5#newcode196
Line 196: static Operand ParameterOperand(const CodeGenerator* cgen, int index)
{
Extra whitespace at end of line?

Powered by Google App Engine
This is Rietveld 408576698