Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3987)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_mac.mm

Issue 566018: [Mac] Revert diagnostics for content popup bug. (Closed)
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/chrome/browser/renderer_host/render_widget_host_view_mac.mm b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
index 382fafbf60e04101e730a7212beb2596376b684c..d4409e0137e33757302afec74ea5cd4eb4cc34ea 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/chrome/browser/renderer_host/render_widget_host_view_mac.mm
@@ -445,7 +445,6 @@ void RenderWidgetHostViewMac::ShowPopupWithItems(
if ([menu_runner menuItemWasChosen]) {
// Simulate a menu selection event.
- CHECK(cocoa_view_);
const WebMouseEvent& mouse_event =
WebInputEventFactory::mouseEvent(event, cocoa_view_);
render_widget_host_->ForwardMouseEvent(mouse_event);
@@ -602,13 +601,6 @@ void RenderWidgetHostViewMac::SetBackground(const SkBitmap& background) {
return self;
}
-// Used only to diagnose the crash in http://crbug.com/31716
-// TODO(pamg): Remove when no longer needed.
-- (void)dealloc {
- renderWidgetHostView_->clear_cocoa_view();
- [super dealloc];
-}
-
- (void)setCanBeKeyView:(BOOL)can {
canBeKeyView_ = can;
}
« no previous file with comments | « chrome/browser/renderer_host/render_widget_host_view_mac.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698