Issue 5652007: Update cbuildbot.py to use emptytree option instead of deleting board.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5652007: Update cbuildbot.py to use emptytree option instead of deleting board. (Closed)

Created:
10 years ago by davidjames

Modified:
9 years, 4 months ago

Reviewers:
diandersAtChromium, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa, kliegs

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

Update cbuildbot.py to use emptytree option instead of deleting board. This allows us to avoid deleting the board and still ensure our packages are in sync with the full buildbot. This allows us to detect conflicts between old and new packages. BUG=chromium-os:10127 TEST=Run cbuildbot.py with emptytree feature forced to on and verify that build_packages rebuilds all packages. Also run unit tests. Change-Id: I83e186937e28eef44285724697895a4583910b58 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=ab5c691

Patch Set 1 #

Total comments: 1

Patch Set 2 : Address nit #

Created: 10 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -5 lines)			Patch
	M	bin/cbuildbot.py	View	1	3 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM http://codereview.chromium.org/5652007/diff/1/bin/cbuildbot.py File bin/cbuildbot.py (right): http://codereview.chromium.org/5652007/diff/1/bin/cbuildbot.py#newcode349 bin/cbuildbot.py:349: cmd.insert(0, 'EXTRA_BOARD_FLAGS=--emptytree') extra line

10 years ago (2010-12-09 18:37:47 UTC) #2

diandersAtChromium

10 years ago (2010-12-09 18:58:20 UTC) #3

LGTM also, though I'm not a portage expert.

As I mentioned to David in the hall, there may be side effects of this. 
Hopefully we've thought through all of them.  One I know of is that (I think)
this may cause virtual dependencies to be resolved differently in some cases. 
That shouldn't cause a problem for the buildbot in most cases, I think.  I would
imagine that there might be other differences?

If we get into trouble, I assume that the right thing will be to get one of the
people with access to the buildbots to manually blow away the appropriate build
directory?

Expand Messages | Collapse Messages