Issue 565050: gtk: Remove Backspace and Shift-Backspace accelerators.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 565050: gtk: Remove Backspace and Shift-Backspace accelerators. (Closed)

Created:
10 years, 10 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, Evan Stade

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Visibility:
Public.

gtk: Remove Backspace and Shift-Backspace accelerators. I am doing this for platform compatibility on Linux: per http://kb.mozillazine.org/Browser.backspace_action, these accelerators have been disabled by default in Firefox since 2006-12-07. They are also not present in Epiphany or Midori. BUG=30699 TEST=tried them; they do nothing now Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=38074

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -2 lines)			Patch
	M	chrome/browser/gtk/accelerators_gtk.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Evan Martin

10 years, 10 months ago (2010-02-04 02:13:41 UTC) #3

We discussed this in person and I think it's good, but I suggested we let Mr.
Stade do the final LGTM