Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Unified Diff: webkit/appcache/appcache_update_job.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/jingle_glue/xmpp_socket_adapter.h ('k') | webkit/glue/plugins/pepper_buffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/appcache/appcache_update_job.h
diff --git a/webkit/appcache/appcache_update_job.h b/webkit/appcache/appcache_update_job.h
index dacff44a76f3ae457103b95620c656f8328e1247..8b75312de6355015383bfe97c60f1666729381a0 100644
--- a/webkit/appcache/appcache_update_job.h
+++ b/webkit/appcache/appcache_update_job.h
@@ -102,15 +102,17 @@ class AppCacheUpdateJob : public net::URLRequest::Delegate,
// TODO(jennb): any other delegate callbacks to handle? certificate?
// Methods for AppCacheStorage::Delegate.
- void OnResponseInfoLoaded(AppCacheResponseInfo* response_info,
- int64 response_id);
- void OnGroupAndNewestCacheStored(AppCacheGroup* group, AppCache* newest_cache,
- bool success, bool would_exceed_quota);
- void OnGroupMadeObsolete(AppCacheGroup* group, bool success);
+ virtual void OnResponseInfoLoaded(AppCacheResponseInfo* response_info,
+ int64 response_id);
+ virtual void OnGroupAndNewestCacheStored(AppCacheGroup* group,
+ AppCache* newest_cache,
+ bool success,
+ bool would_exceed_quota);
+ virtual void OnGroupMadeObsolete(AppCacheGroup* group, bool success);
// Methods for AppCacheHost::Observer.
- void OnCacheSelectionComplete(AppCacheHost* host) {} // N/A
- void OnDestructionImminent(AppCacheHost* host);
+ virtual void OnCacheSelectionComplete(AppCacheHost* host) {} // N/A
+ virtual void OnDestructionImminent(AppCacheHost* host);
void CheckPolicy();
void OnPolicyCheckComplete(int rv);
« no previous file with comments | « remoting/jingle_glue/xmpp_socket_adapter.h ('k') | webkit/glue/plugins/pepper_buffer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698