net/base/listen_socket.h - Issue 5648004: Add the "virtual" keyword on method overrides that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/listen_socket.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/listen_socket.h

diff --git a/net/base/listen_socket.h b/net/base/listen_socket.h

index 7ce8887677dbdbe62c98cc46251b296bf9b0c94d..e730b82212d5a76ea4c34a5b1e681e68f5c64590 100644

--- a/net/base/listen_socket.h

+++ b/net/base/listen_socket.h

@@ -114,8 +114,8 @@ class ListenSocket : public base::RefCountedThreadSafe<ListenSocket>,

// The socket's libevent wrapper

MessageLoopForIO::FileDescriptorWatcher watcher_;

// Called by MessagePumpLibevent when the socket is ready to do I/O

- void OnFileCanReadWithoutBlocking(int fd);

- void OnFileCanWriteWithoutBlocking(int fd);

+ virtual void OnFileCanReadWithoutBlocking(int fd);

+ virtual void OnFileCanWriteWithoutBlocking(int fd);

#endif

SOCKET socket_;

« no previous file with comments | « net/base/directory_lister.h ('k') | net/http/http_auth_handler_basic.h » ('j') | no next file with comments »