Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: chrome/renderer/geolocation_dispatcher_old.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/plugin/webplugin_proxy.cc ('k') | chrome/renderer/media/audio_renderer_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/geolocation_dispatcher_old.h
diff --git a/chrome/renderer/geolocation_dispatcher_old.h b/chrome/renderer/geolocation_dispatcher_old.h
index 41473f3d42299acb58b1afe13a542634cb0c7991..57f7d8a6285665ef1633a9b1225b9d8a8932103b 100644
--- a/chrome/renderer/geolocation_dispatcher_old.h
+++ b/chrome/renderer/geolocation_dispatcher_old.h
@@ -33,16 +33,18 @@ class GeolocationDispatcherOld : public WebKit::WebGeolocationService {
bool OnMessageReceived(const IPC::Message& msg);
// WebKit::WebGeolocationService.
- void requestPermissionForFrame(int bridge_id, const WebKit::WebURL& url);
- void cancelPermissionRequestForFrame(
+ virtual void requestPermissionForFrame(int bridge_id,
+ const WebKit::WebURL& url);
+ virtual void cancelPermissionRequestForFrame(
int bridge_id, const WebKit::WebURL& url);
- void startUpdating(
+ virtual void startUpdating(
int bridge_id, const WebKit::WebURL& url, bool enableHighAccuracy);
- void stopUpdating(int bridge_id);
- void suspend(int bridge_id);
- void resume(int bridge_id);
- int attachBridge(WebKit::WebGeolocationServiceBridge* geolocation_service);
- void detachBridge(int bridge_id);
+ virtual void stopUpdating(int bridge_id);
+ virtual void suspend(int bridge_id);
+ virtual void resume(int bridge_id);
+ virtual int attachBridge(
+ WebKit::WebGeolocationServiceBridge* geolocation_service);
+ virtual void detachBridge(int bridge_id);
private:
// Permission for using geolocation has been set.
« no previous file with comments | « chrome/plugin/webplugin_proxy.cc ('k') | chrome/renderer/media/audio_renderer_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698