Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4497)

Unified Diff: chrome/plugin/plugin_channel.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/plugin/npobject_stub.cc ('k') | chrome/plugin/webplugin_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/plugin/plugin_channel.h
diff --git a/chrome/plugin/plugin_channel.h b/chrome/plugin/plugin_channel.h
index cc444c054cafa4145a9660cd838ad08e75364182..2c00cf837d47c35606ba9eff630374b291fd64f1 100644
--- a/chrome/plugin/plugin_channel.h
+++ b/chrome/plugin/plugin_channel.h
@@ -30,7 +30,7 @@ class PluginChannel : public PluginChannelBase {
// Send a message to all renderers that the process is going to shutdown.
static void NotifyRenderersOfPendingShutdown();
- ~PluginChannel();
+ virtual ~PluginChannel();
virtual bool Send(IPC::Message* msg);
virtual void OnMessageReceived(const IPC::Message& message);
@@ -38,7 +38,7 @@ class PluginChannel : public PluginChannelBase {
base::ProcessHandle renderer_handle() const { return renderer_handle_; }
int renderer_id() { return renderer_id_; }
- int GenerateRouteID();
+ virtual int GenerateRouteID();
// Returns the event that's set when a call to the renderer causes a modal
// dialog to come up.
@@ -69,7 +69,7 @@ class PluginChannel : public PluginChannelBase {
// Called on the plugin thread
PluginChannel();
- void OnControlMessageReceived(const IPC::Message& msg);
+ virtual void OnControlMessageReceived(const IPC::Message& msg);
static PluginChannelBase* ClassFactory() { return new PluginChannel(); }
« no previous file with comments | « chrome/plugin/npobject_stub.cc ('k') | chrome/plugin/webplugin_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698