chrome/browser/extensions/sandboxed_extension_unpacker.h - Issue 5648004: Add the "virtual" keyword on method overrides that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/sandboxed_extension_unpacker.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/sandboxed_extension_unpacker.h

diff --git a/chrome/browser/extensions/sandboxed_extension_unpacker.h b/chrome/browser/extensions/sandboxed_extension_unpacker.h

index 84384825bd62fd3f7677367ab2e1742245f030a6..acb408109ceae5884f2a1b69f1b8c7a1eec17b0e 100644

--- a/chrome/browser/extensions/sandboxed_extension_unpacker.h

+++ b/chrome/browser/extensions/sandboxed_extension_unpacker.h

@@ -122,9 +122,9 @@ class SandboxedExtensionUnpacker : public UtilityProcessHost::Client {

void StartProcessOnIOThread(const FilePath& temp_crx_path);

// SandboxedExtensionUnpacker

- void OnUnpackExtensionSucceeded(const DictionaryValue& manifest);

- void OnUnpackExtensionFailed(const std::string& error_message);

- void OnProcessCrashed();

+ virtual void OnUnpackExtensionSucceeded(const DictionaryValue& manifest);

+ virtual void OnUnpackExtensionFailed(const std::string& error_message);

+ virtual void OnProcessCrashed();

void ReportFailure(const std::string& message);

void ReportSuccess();