Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: chrome/browser/extensions/extensions_service.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extensions_service.h
diff --git a/chrome/browser/extensions/extensions_service.h b/chrome/browser/extensions/extensions_service.h
index d3e67438983a4caf467e3e64f3bace368ea698a3..1db154f82ba180fe1fe667358e2f18165aa2147d 100644
--- a/chrome/browser/extensions/extensions_service.h
+++ b/chrome/browser/extensions/extensions_service.h
@@ -219,10 +219,8 @@ class ExtensionsService
void InitEventRouters();
// Look up an extension by ID.
- const Extension* GetExtensionById(const std::string& id,
- bool include_disabled) {
- return GetExtensionByIdInternal(id, true, include_disabled);
- }
+ virtual const Extension* GetExtensionById(const std::string& id,
+ bool include_disabled);
// Install the extension file at |extension_path|. Will install as an
// update if an older version is already installed.
@@ -406,7 +404,7 @@ class ExtensionsService
// it.
void DestroyingProfile();
- ExtensionPrefs* extension_prefs() { return extension_prefs_; }
+ virtual ExtensionPrefs* extension_prefs() { return extension_prefs_; }
// Whether the extension service is ready.
// TODO(skerner): Get rid of this method. crbug.com/63756
« no previous file with comments | « chrome/browser/extensions/extension_message_service.h ('k') | chrome/browser/extensions/extensions_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698