chrome/browser/extensions/extension_browser_event_router.h - Issue 5648004: Add the "virtual" keyword on method overrides that are missing it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_event_router.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Missing file Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browser_event_router.h

diff --git a/chrome/browser/extensions/extension_browser_event_router.h b/chrome/browser/extensions/extension_browser_event_router.h

index e951290fe26efd95b8356bb4d41497d291996d81..cdf2efe556287b7bd6fd92aefbeb199d6ba008fe 100644

--- a/chrome/browser/extensions/extension_browser_event_router.h

+++ b/chrome/browser/extensions/extension_browser_event_router.h

@@ -92,9 +92,9 @@ class ExtensionBrowserEventRouter : public TabStripModelObserver,

Browser* browser);

// NotificationObserver.

- void Observe(NotificationType type,

- const NotificationSource& source,

- const NotificationDetails& details);

+ virtual void Observe(NotificationType type,

+ const NotificationSource& source,

+ const NotificationDetails& details);

private:

// "Synthetic" event. Called from TabInsertedAt if new tab is detected.

void TabCreatedAt(TabContents* contents, int index, bool foreground);