Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: chrome/browser/extensions/extension_bookmarks_module.h

Issue 5648004: Add the "virtual" keyword on method overrides that are missing it. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Missing file Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_bookmarks_module.h
diff --git a/chrome/browser/extensions/extension_bookmarks_module.h b/chrome/browser/extensions/extension_bookmarks_module.h
index e8e91a187909bc56967aaaac5fb4b3589ff5dbd1..10fe373f541c36905b8f27d094fd1dafed5a1001 100644
--- a/chrome/browser/extensions/extension_bookmarks_module.h
+++ b/chrome/browser/extensions/extension_bookmarks_module.h
@@ -179,8 +179,9 @@ class BookmarksIOFunction : public BookmarksFunction,
// Overridden from SelectFileDialog::Listener:
virtual void FileSelected(const FilePath& path, int index, void* params) = 0;
- void MultiFilesSelected(const std::vector<FilePath>& files, void* params);
- void FileSelectionCanceled(void* params);
+ virtual void MultiFilesSelected(const std::vector<FilePath>& files,
+ void* params);
+ virtual void FileSelectionCanceled(void* params);
void SelectFile(SelectFileDialog::Type type);
protected:
@@ -190,8 +191,8 @@ class BookmarksIOFunction : public BookmarksFunction,
class ImportBookmarksFunction : public BookmarksIOFunction {
public:
// Override BookmarkManagerIOFunction.
- bool RunImpl();
- void FileSelected(const FilePath& path, int index, void* params);
+ virtual bool RunImpl();
+ virtual void FileSelected(const FilePath& path, int index, void* params);
private:
DECLARE_EXTENSION_FUNCTION_NAME("bookmarks.import");
@@ -200,8 +201,8 @@ class ImportBookmarksFunction : public BookmarksIOFunction {
class ExportBookmarksFunction : public BookmarksIOFunction {
public:
// Override BookmarkManagerIOFunction.
- bool RunImpl();
- void FileSelected(const FilePath& path, int index, void* params);
+ virtual bool RunImpl();
+ virtual void FileSelected(const FilePath& path, int index, void* params);
private:
DECLARE_EXTENSION_FUNCTION_NAME("bookmarks.export");
« no previous file with comments | « chrome/browser/download/download_request_limiter.h ('k') | chrome/browser/extensions/extension_browser_event_router.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698