Use the RPC channel to set the ID <-> handle mapping....

Use the RPC channel to set the ID <-> handle mapping.

As described in more details in the bug description, if we use COM for these and RPC for the other events, then they could arrive out of order.

BUG=65316
TEST=Create as many tabs as quickly as possible and watch the logs (sawbuck) for errors.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68311

[Jói, 2010-12-04 20:41:49]

LGTM

Thanks MAD.

Did we discuss whether we should try to merge this to M9?  If we decide(d) to do
that, once it is safely landed on trunk and you feel it is well-tested enough
(do we need to e.g. wait until Monday to get some better coverage on it?) please
assign the associated bug to me in WillMerge status.

Cheers,
Jói

http://codereview.chromium.org/5647001/diff/5002/ceee/ie/plugin/bho/browser_h...
File ceee/ie/plugin/bho/browser_helper_object.h (right):

http://codereview.chromium.org/5647001/diff/5002/ceee/ie/plugin/bho/browser_h...
ceee/ie/plugin/bho/browser_helper_object.h:268: // Fires the private message to
map a tool band id to its associated tab
nit: tool band -> toolband

[MAD, 2010-12-04 21:06:29]

We said we would merge it of the fix was small and safe enough... I'll
commit now (as well as the other fix you approved) and we'll see if we want
them in M9 or not...

Thanks!

BYE
MAD
Le 4 déc. 2010 15:41, <joi@chromium.org> a écrit :
> LGTM
>
> Thanks MAD.
>
> Did we discuss whether we should try to merge this to M9? If we decide(d)
> to do
> that, once it is safely landed on trunk and you feel it is well-tested
> enough
> (do we need to e.g. wait until Monday to get some better coverage on it?)
> please
> assign the associated bug to me in WillMerge status.
>
> Cheers,
> Jói
>
>
>
>
http://codereview.chromium.org/5647001/diff/5002/ceee/ie/plugin/bho/browser_h...
> File ceee/ie/plugin/bho/browser_helper_object.h (right):
>
>
http://codereview.chromium.org/5647001/diff/5002/ceee/ie/plugin/bho/browser_h...
> ceee/ie/plugin/bho/browser_helper_object.h:268: // Fires the private
> message to map a tool band id to its associated tab
> nit: tool band -> toolband
>
> http://codereview.chromium.org/5647001/

[MAD, 2010-12-04 21:19:51]

Arghh.... Needed to merge BHO changes, so I'll have to wait till tomorrow to
commit... Gotta go to a birthday dinner...

BYE
MAD

On Sat, Dec 4, 2010 at 4:06 PM, Marc-Andre Decoste <mad@chromium.org> wrote:

> We said we would merge it of the fix was small and safe enough... I'll
> commit now (as well as the other fix you approved) and we'll see if we want
> them in M9 or not...
>
> Thanks!
>
> BYE
> MAD
> Le 4 déc. 2010 15:41, <joi@chromium.org> a écrit :
>
> > LGTM
> >
> > Thanks MAD.
> >
> > Did we discuss whether we should try to merge this to M9? If we decide(d)
>
> > to do
> > that, once it is safely landed on trunk and you feel it is well-tested
> > enough
> > (do we need to e.g. wait until Monday to get some better coverage on it?)
>
> > please
> > assign the associated bug to me in WillMerge status.
> >
> > Cheers,
> > Jói
> >
> >
> >
> >
>
http://codereview.chromium.org/5647001/diff/5002/ceee/ie/plugin/bho/browser_h...
> > File ceee/ie/plugin/bho/browser_helper_object.h (right):
> >
> >
>
http://codereview.chromium.org/5647001/diff/5002/ceee/ie/plugin/bho/browser_h...
> > ceee/ie/plugin/bho/browser_helper_object.h:268: // Fires the private
> > message to map a tool band id to its associated tab
> > nit: tool band -> toolband
> >
> > http://codereview.chromium.org/5647001/
>