Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4665)

Unified Diff: chrome/service/service_process_prefs.cc

Issue 5646003: Sanitize PrefStore interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix PrefService mock construction in PrefServiceTest to include command line store. Created 10 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/service/service_process_prefs.h ('k') | chrome/test/reliability/page_load_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/service/service_process_prefs.cc
diff --git a/chrome/service/service_process_prefs.cc b/chrome/service/service_process_prefs.cc
new file mode 100644
index 0000000000000000000000000000000000000000..182b92f32d565ea077d272418c9c428241062394
--- /dev/null
+++ b/chrome/service/service_process_prefs.cc
@@ -0,0 +1,54 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/service/service_process_prefs.h"
+
+#include "base/values.h"
+
+ServiceProcessPrefs::ServiceProcessPrefs(
+ const FilePath& pref_filename,
+ base::MessageLoopProxy* file_message_loop_proxy)
+ : prefs_(pref_filename, file_message_loop_proxy) {
+}
+
+void ServiceProcessPrefs::ReadPrefs() {
+ prefs_.ReadPrefs();
+}
+
+void ServiceProcessPrefs::WritePrefs() {
+ prefs_.WritePrefs();
+}
+
+void ServiceProcessPrefs::GetString(const std::string& key,
+ std::string* result) {
+ Value* value;
+ if (prefs_.GetValue(key, &value) == PersistentPrefStore::READ_OK)
+ value->GetAsString(result);
+}
+
+void ServiceProcessPrefs::SetString(const std::string& key,
+ const std::string& value) {
+ prefs_.SetValue(key, Value::CreateStringValue(value));
+}
+
+void ServiceProcessPrefs::GetBoolean(const std::string& key, bool* result) {
+ Value* value;
+ if (prefs_.GetValue(key, &value) == PersistentPrefStore::READ_OK)
+ value->GetAsBoolean(result);
+}
+
+void ServiceProcessPrefs::SetBoolean(const std::string& key, bool value) {
+ prefs_.SetValue(key, Value::CreateBooleanValue(value));
+}
+
+void ServiceProcessPrefs::GetDictionary(const std::string& key,
+ DictionaryValue** result) {
+ Value* value;
+ if (prefs_.GetValue(key, &value) != PersistentPrefStore::READ_OK ||
+ !value->IsType(Value::TYPE_DICTIONARY)) {
+ return;
+ }
+
+ *result = static_cast<DictionaryValue*>(value);
+}
« no previous file with comments | « chrome/service/service_process_prefs.h ('k') | chrome/test/reliability/page_load_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698