chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm - Issue 5646003: Sanitize PrefStore interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm

Issue 5646003: Sanitize PrefStore interface. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix PrefService mock construction in PrefServiceTest to include command line store. Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm

diff --git a/chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm

index ac00647e12daed2f292374cd50f819b2a98d9f7f..298711e673b9b4df676d15db74f752db4b2d2c91 100644

--- a/chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm

+++ b/chrome/browser/ui/cocoa/extensions/extension_popup_controller_unittest.mm

@@ -2,7 +2,9 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include "base/message_loop.h"

#include "base/scoped_nsobject.h"

+#include "chrome/browser/extensions/extension_pref_store.h"

#include "chrome/browser/extensions/extension_prefs.h"

#include "chrome/browser/extensions/extension_process_manager.h"

#include "chrome/browser/extensions/extensions_service.h"

@@ -26,8 +28,10 @@ class ExtensionTestingProfile : public TestingProfile {

DCHECK(!GetExtensionsService());

manager_.reset(ExtensionProcessManager::Create(this));

+ ExtensionPrefStore* pref_store = new ExtensionPrefStore;

extension_prefs_.reset(new ExtensionPrefs(GetPrefs(),

- GetExtensionsInstallDir()));

+ GetExtensionsInstallDir(),

+ pref_store));

service_ = new ExtensionsService(this,

CommandLine::ForCurrentProcess(),

GetExtensionsInstallDir(),

« no previous file with comments | « chrome/browser/search_engines/template_url_model_unittest.cc ('k') | chrome/chrome.gyp » ('j') | no next file with comments »