Sanitize PrefStore interface.

chrome/service/service_prefs.cc

Index: chrome/service/service_prefs.cc
diff --git a/chrome/service/service_prefs.cc b/chrome/service/service_prefs.cc
new file mode 100644
index 0000000000000000000000000000000000000000..bc6303a0d80ae5f8a888e3e3b3b68cc848caf8ed
--- /dev/null
+++ b/chrome/service/service_prefs.cc
@@ -0,0 +1,51 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/service/service_prefs.h"
+
+#include "base/values.h"
+
+ServicePrefs::ServicePrefs(const FilePath& pref_filename,
+                           base::MessageLoopProxy* file_message_loop_proxy)
+    : prefs_(pref_filename, file_message_loop_proxy) {
+}
+
+void ServicePrefs::ReadPrefs() {
+  prefs_.ReadPrefs();
+}
+
+void ServicePrefs::WritePrefs() {
+  prefs_.WritePrefs();
+}
+
+void ServicePrefs::GetString(const std::string& key, std::string* result) {
+  Value* value;
+  if (prefs_.GetValue(key, &value) == PersistentPrefStore::READ_OK)
+    value->GetAsString(result);
+}
+
+void ServicePrefs::SetString(const std::string& key, const std::string& value) {
+  prefs_.SetValue(key, Value::CreateStringValue(value));
+}
+
+void ServicePrefs::GetBoolean(const std::string& key, bool* result) {
+  Value* value;
+  if (prefs_.GetValue(key, &value) == PersistentPrefStore::READ_OK)
+    value->GetAsBoolean(result);

[gfeher, 2010/12/08 12:34:35]

How about indicating missing prefs to the consumer in a more explicit way, like
with a bool return value?

I admit I don't yet understand the role of ServicePrefs.

[Mattias Nissler (ping if slow), 2010/12/09 10:20:20]

If the consumers would need that. But so far they don't, so lets add it once we
need it.

+}
+
+void ServicePrefs::SetBoolean(const std::string& key, bool value) {
+  prefs_.SetValue(key, Value::CreateBooleanValue(value));
+}
+
+void ServicePrefs::GetDictionary(const std::string& key,
+                                 DictionaryValue** result) {
+  Value* value;
+  if (prefs_.GetValue(key, &value) != PersistentPrefStore::READ_OK ||
+      !value->IsType(Value::TYPE_DICTIONARY)) {
+    return;
+  }
+
+  *result = static_cast<DictionaryValue*>(value);
+}