Sanitize PrefStore interface.

chrome/browser/prefs/value_map_pref_store.h

Index: chrome/browser/prefs/value_map_pref_store.h
diff --git a/chrome/browser/prefs/value_map_pref_store.h b/chrome/browser/prefs/value_map_pref_store.h
new file mode 100644
index 0000000000000000000000000000000000000000..96c9cbb293533de8533d2a78ad25a33e6a52873b
--- /dev/null
+++ b/chrome/browser/prefs/value_map_pref_store.h
@@ -0,0 +1,48 @@
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
+#define CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_
+#pragma once
+
+#include <map>
+
+#include "base/basictypes.h"
+#include "base/observer_list.h"
+#include "chrome/common/pref_store.h"
+#include "chrome/browser/prefs/pref_value_map.h"

[danno, 2010/12/08 13:08:45]

alpha

[Mattias Nissler (ping if slow), 2010/12/09 10:20:20]

Done.

+
+// A basic PrefStore implementation that uses a simple name-value map for
+// storing the preference values.
+class ValueMapPrefStore : public PrefStore {
+ public:
+  ValueMapPrefStore() {}
+  virtual ~ValueMapPrefStore() {}
+
+  // PrefStore overrides:
+  virtual ReadResult GetValue(const std::string& key, Value** value) const;
+  virtual void AddObserver(PrefStore::ObserverInterface* observer);
+  virtual void RemoveObserver(PrefStore::ObserverInterface* observer);
+
+ protected:
+  // Store a |value| for |key| in the store. Also generates an notification if
+  // the value changed. Assumes ownership of |value|.
+  void SetValue(const std::string& key, Value* value);
+
+  // Remove the value for |key| from the store. Sends a notification if there
+  // was a value to be removed.
+  void RemoveValue(const std::string& key);
+
+  // Notify observers about the initialization completed event.
+  void NotifyInitializationCompleted();
+
+ private:
+  PrefValueMap prefs_;
+
+  ObserverList<PrefStore::ObserverInterface, true> observers_;
+
+  DISALLOW_COPY_AND_ASSIGN(ValueMapPrefStore);
+};
+
+#endif  // CHROME_BROWSER_PREFS_VALUE_MAP_PREF_STORE_H_