Sanitize PrefStore interface.

chrome/browser/prefs/pref_service_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "app/test/data/resource.h"
 #include "base/command_line.h"
 #include "base/scoped_ptr.h"
 #include "base/values.h"
 #include "chrome/browser/policy/configuration_policy_pref_store.h"
 #include "chrome/browser/policy/mock_configuration_policy_provider.h"
 #include "chrome/browser/prefs/browser_prefs.h"
 #include "chrome/browser/prefs/command_line_pref_store.h"
-#include "chrome/browser/prefs/testing_pref_store.h"
 #include "chrome/browser/prefs/pref_change_registrar.h"
 #include "chrome/browser/prefs/pref_observer_mock.h"
+#include "chrome/browser/prefs/pref_service_mock_builder.h"
 #include "chrome/browser/prefs/pref_value_store.h"
+#include "chrome/browser/prefs/testing_pref_store.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/test/testing_pref_service.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using testing::_;
 using testing::Mock;
 
@@ skipping 110 matching lines @@
   // Make sure obs2 still works after removing obs.
   registrar.Remove(pref_name, &obs);
   EXPECT_CALL(obs, Observe(_, _, _)).Times(0);
   obs2.Expect(&prefs, pref_name, &expected_new_pref_value);
   // This should only fire the observer in obs2.
   prefs.SetString(pref_name, new_pref_value);
   Mock::VerifyAndClearExpectations(&obs);
   Mock::VerifyAndClearExpectations(&obs2);
 }
 
-TEST(PrefServiceTest, ProxyFromCommandLineNotPolicy) {
-  CommandLine command_line(CommandLine::NO_PROGRAM);
-  command_line.AppendSwitch(switches::kProxyAutoDetect);
-  TestingPrefService prefs(NULL, NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs);
-  EXPECT_TRUE(prefs.GetBoolean(prefs::kProxyAutoDetect));
-  const PrefService::Preference* pref =
-      prefs.FindPreference(prefs::kProxyAutoDetect);
-  ASSERT_TRUE(pref);
-  EXPECT_FALSE(pref->IsManaged());
-}
-
 TEST(PrefServiceTest, ProxyPolicyOverridesCommandLineOptions) {
   CommandLine command_line(CommandLine::NO_PROGRAM);
   command_line.AppendSwitchASCII(switches::kProxyBypassList, "123");
   command_line.AppendSwitchASCII(switches::kProxyPacUrl, "456");
   command_line.AppendSwitchASCII(switches::kProxyServer, "789");
   scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
       new policy::MockConfigurationPolicyProvider());
   Value* mode_value = Value::CreateIntegerValue(
       policy::kPolicyManuallyConfiguredProxyMode);
   provider->AddPolicy(policy::kPolicyProxyServerMode, mode_value);
   provider->AddPolicy(policy::kPolicyProxyBypassList,
                       Value::CreateStringValue("abc"));
   provider->AddPolicy(policy::kPolicyProxyPacUrl,
                       Value::CreateStringValue("def"));
   provider->AddPolicy(policy::kPolicyProxyServer,
                       Value::CreateStringValue("ghi"));
 
   // First verify that command-line options are set correctly when
   // there is no policy in effect.
-  TestingPrefService prefs(NULL, NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs);
-  EXPECT_FALSE(prefs.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_FALSE(prefs.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ("789", prefs.GetString(prefs::kProxyServer));
-  EXPECT_EQ("456", prefs.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ("123", prefs.GetString(prefs::kProxyBypassList));
+  PrefServiceMockBuilder builder;
+  builder.WithCommandLine(&command_line);
+  scoped_ptr<PrefService> prefs(builder.Create());
+  browser::RegisterUserPrefs(prefs.get());
+  EXPECT_FALSE(prefs->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_FALSE(prefs->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ("789", prefs->GetString(prefs::kProxyServer));
+  EXPECT_EQ("456", prefs->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ("123", prefs->GetString(prefs::kProxyBypassList));
 
   // Try a second time time with the managed PrefStore in place, the
   // manual proxy policy should have removed all traces of the command
   // line and replaced them with the policy versions.
-  TestingPrefService prefs2(provider.get(), NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs2);
-  EXPECT_FALSE(prefs2.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_FALSE(prefs2.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ("ghi", prefs2.GetString(prefs::kProxyServer));
-  EXPECT_EQ("def", prefs2.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ("abc", prefs2.GetString(prefs::kProxyBypassList));
+  builder.WithManagedPlatformProvider(provider.get());

[danno, 2010/12/09 14:14:44]

command line is missing.

[Mattias Nissler (ping if slow), 2010/12/09 14:57:11]

Done.

+  scoped_ptr<PrefService> prefs2(builder.Create());
+  browser::RegisterUserPrefs(prefs2.get());
+  EXPECT_FALSE(prefs2->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_FALSE(prefs2->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ("ghi", prefs2->GetString(prefs::kProxyServer));
+  EXPECT_EQ("def", prefs2->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ("abc", prefs2->GetString(prefs::kProxyBypassList));
 }
 
 TEST(PrefServiceTest, ProxyPolicyOverridesUnrelatedCommandLineOptions) {
   CommandLine command_line(CommandLine::NO_PROGRAM);
   command_line.AppendSwitchASCII(switches::kProxyBypassList, "123");
   command_line.AppendSwitchASCII(switches::kProxyPacUrl, "456");
   command_line.AppendSwitchASCII(switches::kProxyServer, "789");
   scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
       new policy::MockConfigurationPolicyProvider());
   Value* mode_value = Value::CreateIntegerValue(
       policy::kPolicyUseSystemProxyMode);
   provider->AddPolicy(policy::kPolicyProxyServerMode, mode_value);
 
   // First verify that command-line options are set correctly when
   // there is no policy in effect.
-  TestingPrefService prefs(NULL, NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs);
-  EXPECT_FALSE(prefs.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_FALSE(prefs.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ("789", prefs.GetString(prefs::kProxyServer));
-  EXPECT_EQ("456", prefs.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ("123", prefs.GetString(prefs::kProxyBypassList));
+  PrefServiceMockBuilder builder;
+  builder.WithCommandLine(&command_line);
+  scoped_ptr<PrefService> prefs(builder.Create());
+  browser::RegisterUserPrefs(prefs.get());
+  EXPECT_FALSE(prefs->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_FALSE(prefs->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ("789", prefs->GetString(prefs::kProxyServer));
+  EXPECT_EQ("456", prefs->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ("123", prefs->GetString(prefs::kProxyBypassList));
 
   // Try a second time time with the managed PrefStore in place, the
   // no proxy policy should have removed all traces of the command
   // line proxy settings, even though they were not the specific one
   // set in policy.
-  TestingPrefService prefs2(provider.get(), NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs2);
-  EXPECT_FALSE(prefs2.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_FALSE(prefs2.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyServer));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyBypassList));
+  builder.WithManagedPlatformProvider(provider.get());

[danno, 2010/12/09 14:14:44]

command line missing

[Mattias Nissler (ping if slow), 2010/12/09 14:57:11]

Done.

+  scoped_ptr<PrefService> prefs2(builder.Create());
+  browser::RegisterUserPrefs(prefs2.get());
+  EXPECT_FALSE(prefs2->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_FALSE(prefs2->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyServer));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyBypassList));
 }
 
 TEST(PrefServiceTest, ProxyPolicyOverridesCommandLineNoProxy) {
   CommandLine command_line(CommandLine::NO_PROGRAM);
   command_line.AppendSwitch(switches::kNoProxyServer);
   scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
       new policy::MockConfigurationPolicyProvider());
   Value* mode_value = Value::CreateIntegerValue(
       policy::kPolicyAutoDetectProxyMode);
   provider->AddPolicy(policy::kPolicyProxyServerMode, mode_value);
 
   // First verify that command-line options are set correctly when
   // there is no policy in effect.
-  TestingPrefService prefs(NULL, NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs);
-  EXPECT_FALSE(prefs.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_TRUE(prefs.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ(std::string(), prefs.GetString(prefs::kProxyServer));
-  EXPECT_EQ(std::string(), prefs.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ(std::string(), prefs.GetString(prefs::kProxyBypassList));
+  PrefServiceMockBuilder builder;
+  builder.WithCommandLine(&command_line);
+  scoped_ptr<PrefService> prefs(builder.Create());
+  browser::RegisterUserPrefs(prefs.get());
+  EXPECT_FALSE(prefs->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_TRUE(prefs->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ(std::string(), prefs->GetString(prefs::kProxyServer));
+  EXPECT_EQ(std::string(), prefs->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ(std::string(), prefs->GetString(prefs::kProxyBypassList));
 
   // Try a second time time with the managed PrefStore in place, the
   // auto-detect should be overridden. The default pref store must be
   // in place with the appropriate default value for this to work.
-  TestingPrefService prefs2(provider.get(), NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs2);
-  EXPECT_TRUE(prefs2.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_FALSE(prefs2.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyServer));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyBypassList));
+  builder.WithManagedPlatformProvider(provider.get());
+  scoped_ptr<PrefService> prefs2(builder.Create());

[danno, 2010/12/09 14:14:44]

please fix command line missing at all places in this file.

[Mattias Nissler (ping if slow), 2010/12/09 14:57:11]

Done.

+  browser::RegisterUserPrefs(prefs2.get());
+  EXPECT_TRUE(prefs2->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_FALSE(prefs2->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyServer));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyBypassList));
 }
 
 TEST(PrefServiceTest, ProxyPolicyOverridesCommandLineAutoDetect) {
   CommandLine command_line(CommandLine::NO_PROGRAM);
   command_line.AppendSwitch(switches::kProxyAutoDetect);
   scoped_ptr<policy::MockConfigurationPolicyProvider> provider(
       new policy::MockConfigurationPolicyProvider());
   Value* mode_value = Value::CreateIntegerValue(
       policy::kPolicyNoProxyServerMode);
   provider->AddPolicy(policy::kPolicyProxyServerMode, mode_value);
 
   // First verify that the auto-detect is set if there is no managed
   // PrefStore.
-  TestingPrefService prefs(NULL, NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs);
-  EXPECT_TRUE(prefs.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_FALSE(prefs.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ(std::string(), prefs.GetString(prefs::kProxyServer));
-  EXPECT_EQ(std::string(), prefs.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ(std::string(), prefs.GetString(prefs::kProxyBypassList));
+  PrefServiceMockBuilder builder;
+  builder.WithCommandLine(&command_line);
+  scoped_ptr<PrefService> prefs(builder.Create());
+  browser::RegisterUserPrefs(prefs.get());
+  EXPECT_TRUE(prefs->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_FALSE(prefs->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ(std::string(), prefs->GetString(prefs::kProxyServer));
+  EXPECT_EQ(std::string(), prefs->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ(std::string(), prefs->GetString(prefs::kProxyBypassList));
 
   // Try a second time time with the managed PrefStore in place, the
   // auto-detect should be overridden. The default pref store must be
   // in place with the appropriate default value for this to work.
-  TestingPrefService prefs2(provider.get(), NULL, &command_line);
-  browser::RegisterUserPrefs(&prefs2);
-  EXPECT_FALSE(prefs2.GetBoolean(prefs::kProxyAutoDetect));
-  EXPECT_TRUE(prefs2.GetBoolean(prefs::kNoProxyServer));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyServer));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyPacUrl));
-  EXPECT_EQ(std::string(), prefs2.GetString(prefs::kProxyBypassList));
+  builder.WithManagedPlatformProvider(provider.get());
+  scoped_ptr<PrefService> prefs2(builder.Create());
+  browser::RegisterUserPrefs(prefs2.get());
+  EXPECT_FALSE(prefs2->GetBoolean(prefs::kProxyAutoDetect));
+  EXPECT_TRUE(prefs2->GetBoolean(prefs::kNoProxyServer));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyServer));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyPacUrl));
+  EXPECT_EQ(std::string(), prefs2->GetString(prefs::kProxyBypassList));
 }
 
 class PrefServiceSetValueTest : public testing::Test {
  protected:
   static const char kName[];
   static const char kValue[];
 
   PrefServiceSetValueTest()
       : null_value_(Value::CreateNullValue()) {}
 
@@ skipping 75 matching lines @@
   Mock::VerifyAndClearExpectations(&observer_);
 
   EXPECT_CALL(observer_, Observe(_, _, _)).Times(0);
   prefs_.Set(kName, new_value);
   Mock::VerifyAndClearExpectations(&observer_);
 
   observer_.Expect(&prefs_, kName, null_value_.get());
   prefs_.Set(kName, *null_value_);
   Mock::VerifyAndClearExpectations(&observer_);
 }