Add utility function to determine if a locale is valid syntax; this will...

app/l10n_util.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/l10n_util.h"
 
 #if defined(TOOLKIT_USES_GTK)
 #include <glib/gutils.h>
 #endif
 
@@ skipping 11 matching lines @@
 #include "base/path_service.h"
 #include "base/scoped_ptr.h"
 #include "base/string16.h"
 #include "base/string_number_conversions.h"
 #include "base/string_split.h"
 #include "base/sys_string_conversions.h"
 #include "base/utf_string_conversions.h"
 #include "build/build_config.h"
 #include "gfx/canvas.h"
 #include "unicode/rbbi.h"
+#include "unicode/uloc.h"
 
 #if defined(OS_MACOSX)
 #include "app/l10n_util_mac.h"
 #elif defined(OS_WIN)
 #include "app/l10n_util_win.h"
 #endif
 
 namespace {
 
 #if defined(OS_WIN)
@@ skipping 429 matching lines @@
       display_locale.c_str(),
       WriteInto(&display_name, buffer_size + 1), buffer_size, &error);
   DCHECK(U_SUCCESS(error));
   display_name.resize(actual_size);
   // Add an RTL mark so parentheses are properly placed.
   if (is_for_ui && base::i18n::IsRTL())
     display_name.push_back(static_cast<char16>(base::i18n::kRightToLeftMark));
   return display_name;
 }
 
+std::string NormalizeLocale(const std::string& locale) {
+  std::string normalized_locale(locale);
+  std::replace(normalized_locale.begin(), normalized_locale.end(), '-', '_');
+
+  return normalized_locale;
+}
+
+void GetParentLocales(const std::string& current_locale,
+                      std::vector<std::string>* parent_locales) {
+  std::string locale(NormalizeLocale(current_locale));
+
+  const int kNameCapacity = 256;
+  char parent[kNameCapacity];
+  base::strlcpy(parent, locale.c_str(), kNameCapacity);
+  parent_locales->push_back(parent);
+  UErrorCode err = U_ZERO_ERROR;
+  while (uloc_getParent(parent, parent, kNameCapacity, &err) > 0) {
+    if (U_FAILURE(err))
+      break;
+    parent_locales->push_back(parent);
+  }
+}
+
+bool IsValidLocaleSyntax(const std::string& locale) {
+  // This implements a simple approximation of BCP 47; it will accept all
+  // valid strings and reject some (but not all) invalid ones.
+  // http://www.unicode.org/reports/tr35/
+  //     #Unicode_Language_and_Locale_Identifiers

[Nebojša Ćirić, 2010/12/10 21:42:35]

You could move some (url to TR35) to .h file and remove the rest.

+
+  // Check that the length is plausible.
+  if (locale.size() < 2 || locale.size() >= ULOC_FULLNAME_CAPACITY)
+    return false;
+
+  // Strip off the part after an '@' sign, which might contain keywords,
+  // as in en_IE@currency=IEP or fr@collation=phonebook;calendar=islamic-civil.
+  // We don't validate that part much, just check that there's at least one
+  // equals sign in a plausible place.
+  std::string prefix = locale;
+  if (locale.find("@") != std::string::npos) {
+    size_t split_point = locale.find("@");

[Nebojša Ćirić, 2010/12/10 21:42:35]

You could do:
size_t split_point = locale.find("@");
if (split_point != std::string::npos) {
...
}

+    std::string keywords = locale.substr(split_point + 1);
+    prefix = locale.substr(0, split_point);
+
+    size_t equals_loc = keywords.find("=");
+    if (equals_loc == std::string::npos ||
+        equals_loc < 1 || equals_loc > keywords.size() - 2)
+      return false;
+  }
+
+  // Check that all characters before the at-sign are alphanumeric, hyphen,
+  // or underscore.

[Nebojša Ćirić, 2010/12/10 21:42:35]

You could call NormalizeLocale before processing the rest. It would save you
checks for -.

+  for (size_t i = 0; i < prefix.size(); i++) {
+    char ch = prefix[i];
+    if (!IsAsciiAlpha(ch) && !IsAsciiDigit(ch) && ch != '-' && ch != '_')
+      return false;
+  }
+
+  // Check that the initial token (before the first hyphen/underscore)
+  // is 1 - 3 alphabetical characters (a language tag).
+  for (size_t i = 0; i < prefix.size(); i++) {
+    char ch = prefix[i];
+    if (ch == '-' || ch == '_') {
+      if (i < 1 || i > 3)
+        return false;
+      break;
+    }
+    if (!IsAsciiAlpha(ch))
+      return false;
+  }
+
+  // Check that the all tokens after the initial token are 1 - 8 characters.
+  // (Tokenize/StringTokenizer don't work here, they collapse multiple
+  // delimiters into one.)
+  int token_len = 0;
+  int token_index = 0;
+  for (size_t i = 0; i < prefix.size(); i++) {
+    char ch = prefix[i];
+    if (ch == '-' || ch == '_') {
+      if (token_index > 0 && (token_len < 1 || token_len > 8)) {
+        return false;
+      }
+      token_index++;
+      token_len = 0;
+    } else {
+      token_len++;
+    }
+  }
+  if (token_index == 0 && (token_len < 1 || token_len > 3)) {
+    return false;
+  } else if (token_len < 1 || token_len > 8) {
+    return false;
+  }
+
+  return true;
+}
+
 std::wstring GetString(int message_id) {
   return UTF16ToWide(GetStringUTF16(message_id));
 }
 
 std::string GetStringUTF8(int message_id) {
   return UTF16ToUTF8(GetStringUTF16(message_id));
 }
 
 string16 GetStringUTF16(int message_id) {
   ResourceBundle& rb = ResourceBundle::GetSharedInstance();
@@ skipping 381 matching lines @@
   for (size_t i = 0; i < arraysize(kAcceptLanguageList); ++i) {
     if (!IsLocaleNameTranslated(kAcceptLanguageList[i], display_locale))
       // TODO(jungshik) : Put them at the of the list with language codes
       // enclosed by brackets instead of skipping.
         continue;
     locale_codes->push_back(kAcceptLanguageList[i]);
   }
 }
 
 }  // namespace l10n_util