Allow the optimizing code generator to call Math.pow with untagged doubles.

src/ia32/lithium-ia32.h

 // Copyright 2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 49 matching lines @@
 //     LCmpJSObjectEq
 //     LCmpJSObjectEqAndBranch
 //     LCmpT
 //     LDivI
 //     LInstanceOf
 //     LInstanceOfAndBranch
 //     LLoadKeyedFastElement
 //     LLoadKeyedGeneric
 //     LModI
 //     LMulI
+//     LPower
 //     LShiftI
 //     LSubI
 //   LCallConstantFunction
 //   LCallFunction
 //   LCallGlobal
 //   LCallKeyed
 //   LCallKnownGlobal
 //   LCallNamed
 //   LCallRuntime
 //   LCallStub
@@ skipping 53 matching lines @@
 //     LReturn
 //     LSmiTag
 //     LStoreGlobal
 //     LTaggedToI
 //     LThrow
 //     LTypeof
 //     LTypeofIs
 //     LTypeofIsAndBranch
 //     LUnaryMathOperation
 //     LValueOf
-//   LUnknownOSRValue
+//     LUnknownOSRValue

[Florian Schneider, 2010/12/08 14:09:27]

Accidental edit? UnknownOSRValue is not a UnaryOperation.

[William Hesse, 2010/12/08 14:53:16]

Done.

 
 #define LITHIUM_ALL_INSTRUCTION_LIST(V)         \
   V(BinaryOperation)                            \
   V(Constant)                                   \
   V(Call)                                       \
   V(MaterializedLiteral)                        \
   V(StoreKeyed)                                 \
   V(StoreNamed)                                 \
   V(UnaryOperation)                             \
   LITHIUM_CONCRETE_INSTRUCTION_LIST(V)
@@ skipping 68 matching lines @@
   V(LoadNamedField)                             \
   V(LoadNamedGeneric)                           \
   V(ModI)                                       \
   V(MulI)                                       \
   V(NumberTagD)                                 \
   V(NumberTagI)                                 \
   V(NumberUntagD)                               \
   V(ObjectLiteral)                              \
   V(OsrEntry)                                   \
   V(Parameter)                                  \
+  V(Power)                               \

[Florian Schneider, 2010/12/08 14:09:27]

Align \

[William Hesse, 2010/12/08 14:53:16]

Done.

   V(PushArgument)                               \
   V(RegExpLiteral)                              \
   V(Return)                                     \
   V(ShiftI)                                     \
   V(SmiTag)                                     \
   V(SmiUntag)                                   \
   V(StackCheck)                                 \
   V(StoreGlobal)                                \
   V(StoreKeyedFastElement)                      \
   V(StoreKeyedGeneric)                          \
@@ skipping 905 matching lines @@
 class LAddI: public LBinaryOperation {
  public:
   LAddI(LOperand* left, LOperand* right)
       : LBinaryOperation(left, right) { }
 
   DECLARE_CONCRETE_INSTRUCTION(AddI, "add-i")
   DECLARE_HYDROGEN_ACCESSOR(Add)
 };
 
 
+class LPower: public LBinaryOperation {
+ public:
+  LPower(LOperand* left, LOperand* right, Representation exponent_type)
+      : LBinaryOperation(left, right), exponent_type_(exponent_type) { }
+
+  DECLARE_CONCRETE_INSTRUCTION(Power, "power")
+  Representation exponent_type() { return exponent_type_; }

[Florian Schneider, 2010/12/08 14:09:27]

You can save the exponent_type_ member here and get the representation of the
expononent from the H-instruction via the hydrogen()-accessor 

return hydrogen()->right()->representation()

and by declaring: 

DECLARE_HYDROGEN_ACCESSOR(Power)

[William Hesse, 2010/12/08 14:53:16]

Done.

[William Hesse, 2010/12/08 14:53:16]

Done.

+
+ private:
+  Representation exponent_type_;
+};
+
+
 class LArithmeticD: public LBinaryOperation {
  public:
   LArithmeticD(Token::Value op, LOperand* left, LOperand* right)
       : LBinaryOperation(left, right), op_(op) { }
 
   Token::Value op() const { return op_; }
 
   virtual void CompileToNative(LCodeGen* generator);
   virtual const char* Mnemonic() const;
 
@@ skipping 894 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(LChunkBuilder);
 };
 
 #undef DECLARE_HYDROGEN_ACCESSOR
 #undef DECLARE_INSTRUCTION
 #undef DECLARE_CONCRETE_INSTRUCTION
 
 } }  // namespace v8::internal
 
 #endif  // V8_IA32_LITHIUM_IA32_H_