Issue 5640003: libcros: Watch for display brightness changes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5640003: libcros: Watch for display brightness changes. (Closed)

Created:
10 years ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
Charlie Lee

CC:
chromium-os-reviews_chromium.org, DaveMoore

Base URL:
ssh://git@gitrw.chromium.org:9222/cros.git@master

Visibility:
Public.

Description

libcros: Watch for display brightness changes. This adds a function that Chrome can use to get notified when the power manager sends a D-Bus signal saying that the user has changed the display's brightness. BUG=chromium-os:4816 TEST=built and installed this and a corresponding Chrome patch; then checked that Chrome is notified when I press the brightness keys Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7537f1e

Patch Set 1 #

Patch Set 2 : increment version #

Patch Set 3 : update a comment #

Patch Set 4 : replace some CHECK()s with LOG(DFATAL) #

Patch Set 5 : update comment #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -22 lines)			Patch
M	SConstruct.chromiumos	View		1 chunk	+23 lines, -21 lines	0 comments	Download
A	chromeos_brightness.h	View	1 2	1 chunk	+30 lines, -0 lines	0 comments	Download
A	chromeos_brightness.cc	View	1 2 3 4	1 chunk	+128 lines, -0 lines	0 comments	Download
M	chromeos_cros_api.h	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	load.cc	View		3 chunks	+12 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages