OLD | NEW |
| 1 2010-12-07 Alexey Marinichev <amarinichev@chromium.org> |
| 2 |
| 3 Reviewed by James Robinson. |
| 4 |
| 5 [chromium] compositor lost context recovery fix |
| 6 https://bugs.webkit.org/show_bug.cgi?id=50614 |
| 7 |
| 8 To test, load a page that triggers the compositor, kill the GPU |
| 9 process and hover over a link to redraw and thus restart the GPU |
| 10 process. Without this patch it will assert in |
| 11 ContentLayerChromium::updateTextureRect; with this patch it will not. |
| 12 |
| 13 * platform/graphics/chromium/LayerChromium.cpp: |
| 14 (WebCore::LayerChromium::setNeedsDisplay): |
| 15 |
| 16 2010-12-07 Chris Marrin <cmarrin@apple.com> |
| 17 |
| 18 Reviewed by Simon Fraser. |
| 19 |
| 20 Share code between Mac (CA) and Windows (CACF) GraphicsLayer implementat
ions |
| 21 https://bugs.webkit.org/show_bug.cgi?id=49388 |
| 22 |
| 23 Added copy constructors and casting operators to go between |
| 24 TransformationMatrix and CATransform3D. Also added a copy |
| 25 constructor to go from CGAffineTransform to TransformationMatrix. |
| 26 Used these new methods to clean up platform CA code. This will |
| 27 make it easier to port to Windows. |
| 28 |
| 29 I also fixed a couple of build issues found when trying out a |
| 30 Windows build. |
| 31 |
| 32 * WebCore.xcodeproj/project.pbxproj: |
| 33 * platform/graphics/ca/GraphicsLayerCA.cpp: |
| 34 (WebCore::GraphicsLayerCA::ensureCloneLayers): |
| 35 (WebCore::GraphicsLayerCA::fetchCloneLayers): |
| 36 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: |
| 37 (PlatformCAAnimation::setFromValue): |
| 38 (PlatformCAAnimation::setToValue): |
| 39 (PlatformCAAnimation::setValues): |
| 40 * platform/graphics/ca/mac/PlatformCALayerMac.mm: |
| 41 (PlatformCALayer::transform): |
| 42 (PlatformCALayer::setTransform): |
| 43 (PlatformCALayer::sublayerTransform): |
| 44 (PlatformCALayer::setSublayerTransform): |
| 45 (PlatformCALayer::contentsTransform): |
| 46 (PlatformCALayer::setContentsTransform): |
| 47 * platform/graphics/cg/TransformationMatrixCG.cpp: |
| 48 (WebCore::TransformationMatrix::TransformationMatrix): |
| 49 * platform/graphics/transforms/TransformationMatrix.h: |
| 50 |
| 51 2010-12-07 Anders Carlsson <andersca@apple.com> |
| 52 |
| 53 Fix the last clang++ build error. |
| 54 |
| 55 * platform/graphics/ca/mac/PlatformCALayerMac.mm: |
| 56 (PlatformCALayer::animationForKey): |
| 57 Cast the returned animation to the correct type. |
| 58 |
| 59 2010-12-07 Anders Carlsson <andersca@apple.com> |
| 60 |
| 61 Fix some clang++ build errors. |
| 62 |
| 63 * platform/graphics/ca/GraphicsLayerCA.cpp: |
| 64 (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): |
| 65 Remove unused variable. |
| 66 |
| 67 * platform/graphics/ca/mac/PlatformCAAnimationMac.mm: |
| 68 * platform/graphics/ca/mac/PlatformCALayerMac.mm: |
| 69 Fix constness of pointers. |
| 70 |
| 71 2010-12-07 Simon Fraser <simon.fraser@apple.com> |
| 72 |
| 73 Reviewed by Chris Marrin. |
| 74 |
| 75 Fix the Color -> CGColorRef conversions for the debug colors |
| 76 used for compositing layers. |
| 77 |
| 78 * platform/graphics/ca/mac/PlatformCALayerMac.mm: |
| 79 (PlatformCALayer::setBackgroundColor): |
| 80 (PlatformCALayer::setBorderColor): |
| 81 |
| 82 2010-12-07 Brian Weinstein <bweinstein@apple.com> |
| 83 |
| 84 Reviewed by John Sullivan. |
| 85 |
| 86 Part of Layering Violation in ContextMenu |
| 87 https://bugs.webkit.org/show_bug.cgi?id=50586 |
| 88 |
| 89 ContextMenuMac.mm had a WebCoreMenuTarget class, which was responsible f
or wrapping |
| 90 a ContextMenuItem, and calling through to the ContextMenuController to v
alidate it |
| 91 and call a function when it was selected. |
| 92 |
| 93 It was a layering violation to have this class here, because ContextMenu
can't know |
| 94 about ContextMenuController. |
| 95 |
| 96 This patch moves the class that wraps the ContextMenuItems to WebKit/mac
/WebHTMLView.mm, |
| 97 and sets up the menu targets there. |
| 98 |
| 99 No change in behavior, no new tests. |
| 100 |
| 101 * WebCore.exp.in: Added function that needs to be exported. |
| 102 * platform/mac/ContextMenuMac.mm: |
| 103 (WebCore::ContextMenu::ContextMenu): Don't set the sharedMenuTarget anym
ore. |
| 104 (WebCore::ContextMenu::appendItem): Don't call setMenuItemTarget (this i
s done in WebKit now). |
| 105 (WebCore::ContextMenu::insertItem): Ditto. |
| 106 |
| 107 2010-12-07 Simon Fraser <simon.fraser@apple.com> |
| 108 |
| 109 Reviewed by Dan Bernstein. |
| 110 |
| 111 -webkit-transition Fails on Multiple text-shadow Shadows |
| 112 https://bugs.webkit.org/show_bug.cgi?id=42281 |
| 113 |
| 114 When transitioning multiple shadows, the blend function for |
| 115 ShadowData dropped all but the first and last shadow because |
| 116 of a failure to append to the end of the list. Fixed. |
| 117 |
| 118 Test: transitions/multiple-text-shadow-transition.html |
| 119 |
| 120 * page/animation/AnimationBase.cpp: |
| 121 (WebCore::PropertyWrapperShadow::blend): |
| 122 |
| 123 2010-12-07 Simon Fraser <simon.fraser@apple.com> |
| 124 |
| 125 Reviewed by Beth Dakin. |
| 126 |
| 127 CSS animation doesn't work for border-radius |
| 128 https://bugs.webkit.org/show_bug.cgi?id=48340 |
| 129 |
| 130 Include CSSPropertyBorderRadius in the list of shorthand |
| 131 properties, so that the individual border-radius properties |
| 132 get animated. |
| 133 |
| 134 Test: transitions/border-radius-transition.html |
| 135 |
| 136 * page/animation/AnimationBase.cpp: |
| 137 (WebCore::addShorthandProperties): |
| 138 |
| 139 2010-12-07 Maciej Stachowiak <mjs@apple.com> |
| 140 |
| 141 Reviewed by Kent Tamura. |
| 142 |
| 143 Implement HTML5 hidden attribute |
| 144 https://bugs.webkit.org/show_bug.cgi?id=40511 |
| 145 |
| 146 Test: fast/html/hidden-attr.html |
| 147 |
| 148 * html/HTMLElement.cpp: |
| 149 (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped at
tribute. |
| 150 (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to di
splay: none. |
| 151 |
| 152 2010-12-07 Kenneth Russell <kbr@google.com> |
| 153 |
| 154 Reviewed by David Levin. |
| 155 |
| 156 Fix compilation of core web audio files on Windows |
| 157 https://bugs.webkit.org/show_bug.cgi?id=50603 |
| 158 |
| 159 Changed a few constructs using C99 features of math.h to use |
| 160 wtf/MathExtras.h instead. Changed inline definitions of a couple of |
| 161 const static doubles in classes to out-of-line. Built Chrome with |
| 162 web audio enabled on Windows and Mac OS X to test these changes. |
| 163 |
| 164 No new tests since audio API is not yet implemented. |
| 165 |
| 166 * WebCore.gypi: |
| 167 * platform/audio/AudioResampler.cpp: |
| 168 * platform/audio/Biquad.cpp: |
| 169 (WebCore::Biquad::setLowpassParams): |
| 170 (WebCore::Biquad::setHighpassParams): |
| 171 (WebCore::Biquad::setLowShelfParams): |
| 172 * platform/audio/Cone.cpp: |
| 173 (WebCore::ConeEffect::gain): |
| 174 * platform/audio/EqualPowerPanner.cpp: |
| 175 (WebCore::EqualPowerPanner::pan): |
| 176 * platform/audio/FFTFrame.cpp: |
| 177 (WebCore::FFTFrame::interpolateFrequencyComponents): |
| 178 (WebCore::FFTFrame::extractAverageGroupDelay): |
| 179 (WebCore::FFTFrame::addConstantGroupDelay): |
| 180 * platform/audio/HRTFKernel.cpp: |
| 181 * platform/audio/HRTFPanner.cpp: |
| 182 * webaudio/AudioBufferSourceNode.cpp: |
| 183 (WebCore::AudioBufferSourceNode::readFromBufferWithGrainEnvelope): |
| 184 * webaudio/AudioPannerNode.cpp: |
| 185 (WebCore::AudioPannerNode::getAzimuthElevation): |
| 186 * webaudio/AudioParam.cpp: Added. |
| 187 (AudioParam::setValue): |
| 188 (AudioParam::smooth): |
| 189 * webaudio/AudioParam.h: |
| 190 * webaudio/RealtimeAnalyser.cpp: |
| 191 |
| 192 2010-11-25 Philippe Normand <pnormand@igalia.com> |
| 193 |
| 194 Reviewed by Martin Robinson. |
| 195 |
| 196 [GStreamer] faster elements linking |
| 197 https://bugs.webkit.org/show_bug.cgi?id=50067 |
| 198 |
| 199 Perform less checks during GStreamer elements linking if building |
| 200 against GStreamer >= 0.10.30. |
| 201 |
| 202 * platform/graphics/gstreamer/GStreamerGWorld.cpp: |
| 203 (WebCore::GStreamerGWorld::enterFullscreen): |
| 204 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
| 205 (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin): |
| 206 |
| 207 2010-12-07 Philippe Normand <pnormand@igalia.com> |
| 208 |
| 209 Reviewed by Gustavo Noronha Silva. |
| 210 |
| 211 [GStreamer] ::buffered() should return multiple ranges in some cases |
| 212 https://bugs.webkit.org/show_bug.cgi?id=45101 |
| 213 |
| 214 Improved the ::buffered() method thanks to the new buffering query |
| 215 support that landed in GStreamer 0.10.31. The method now |
| 216 queries the media buffered-ranges on the pipeline and queue2 |
| 217 handles it if it's buffering the media to disk. |
| 218 |
| 219 The webkitwebsrc element also gained BYTES duration query |
| 220 support. This is needed in the rare cases where uridecodebin |
| 221 configures its queue before the HTTP server returns the media |
| 222 Content-Length. |
| 223 |
| 224 Test: http/tests/media/video-buffered.html |
| 225 |
| 226 * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: |
| 227 (WebCore::MediaPlayerPrivateGStreamer::buffered): |
| 228 * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp: |
| 229 (webkit_web_src_init): |
| 230 (webKitWebSrcQuery): Make webkitwebsrc handle the duration queries |
| 231 if it's aware of the media content-length. |
| 232 * platform/gtk/RenderThemeGtk.cpp: |
| 233 (WebCore::RenderThemeGtk::paintMediaSliderTrack): Fix position of |
| 234 the second and next buffered ranges. |
| 235 |
| 236 2010-12-07 Yael Aharon <yael.aharon@nokia.com> |
| 237 |
| 238 Reviewed by Antonio Gomes. |
| 239 |
| 240 Spatial navigation not Working for Map and Area Tags |
| 241 https://bugs.webkit.org/show_bug.cgi?id=47142 |
| 242 |
| 243 Give area elements special treatment in spatial navigation algorithm by
getting the |
| 244 rect of the area from the associated image. Since area elements are like
ly to overlap |
| 245 if they are not rects, or if authors are not careful, we flatten the rec
t of area elements. |
| 246 |
| 247 Tests: fast/spatial-navigation/snav-imagemap-area-not-focusable.html |
| 248 fast/spatial-navigation/snav-imagemap-area-without-image.html |
| 249 fast/spatial-navigation/snav-imagemap-overlapped-areas.html |
| 250 fast/spatial-navigation/snav-imagemap-simple.html |
| 251 |
| 252 * page/FocusController.cpp: |
| 253 (WebCore::FocusController::findFocusCandidateInContainer): |
| 254 (WebCore::FocusController::advanceFocusDirectionallyInContainer): |
| 255 (WebCore::FocusController::advanceFocusDirectionally): |
| 256 * page/SpatialNavigation.cpp: |
| 257 (WebCore::FocusCandidate::FocusCandidate): |
| 258 (WebCore::virtualRectForDirection): |
| 259 (WebCore::virtualRectForAreaElementAndDirection): |
| 260 * page/SpatialNavigation.h: |
| 261 (WebCore::FocusCandidate::FocusCandidate): |
| 262 |
| 263 2010-12-07 Darin Adler <darin@apple.com> |
| 264 |
| 265 Try to fix V8 build. |
| 266 |
| 267 * bindings/generic/BindingDOMWindow.h: |
| 268 (WebCore::BindingDOMWindow::createWindow): Pass security origin. |
| 269 |
| 270 2010-12-07 Darin Adler <darin@apple.com> |
| 271 |
| 272 Another build fix. |
| 273 |
| 274 * loader/CrossOriginAccessControl.cpp: Added a missing include. |
| 275 |
| 276 2010-12-07 Darin Adler <darin@apple.com> |
| 277 |
| 278 Try to fix build. |
| 279 |
| 280 * plugins/PluginView.cpp: |
| 281 (WebCore::PluginView::start): Pass security origin. |
| 282 (WebCore::PluginView::getURLNotify): Ditto. |
| 283 (WebCore::PluginView::getURL): Ditto. |
| 284 (WebCore::PluginView::handlePost): Ditto. |
| 285 |
| 286 2010-12-06 Darin Adler <darin@apple.com> |
| 287 |
| 288 Reviewed by Sam Weinig. |
| 289 |
| 290 Pass security origin to make local file decision correctly |
| 291 https://bugs.webkit.org/show_bug.cgi?id=48603 |
| 292 |
| 293 * bindings/generic/BindingDOMWindow.h: |
| 294 (WebCore::BindingDOMWindow::createWindow): Pass security origin. |
| 295 (WebCore::BindingDOMWindow::open): Ditto. |
| 296 * bindings/generic/BindingFrame.h: |
| 297 (WebCore::BindingFrame::navigateIfAllowed): Ditto. |
| 298 |
| 299 * bindings/js/JSDOMWindowCustom.cpp: |
| 300 (WebCore::JSDOMWindow::setLocation): Pass security origin. |
| 301 (WebCore::createWindow): Ditto. |
| 302 (WebCore::JSDOMWindow::open): Ditto. |
| 303 |
| 304 * bindings/js/JSDocumentCustom.cpp: |
| 305 (WebCore::JSDocument::setLocation): Pass security origin. |
| 306 |
| 307 * dom/Document.cpp: |
| 308 (WebCore::Document::processHttpEquiv): Pass security origin. |
| 309 |
| 310 * inspector/InspectorController.cpp: |
| 311 (WebCore::InspectorController::openInInspectedWindow): |
| 312 Pass security origin. |
| 313 |
| 314 * loader/FrameLoader.cpp: |
| 315 (WebCore::FrameLoader::changeLocation): Added a security origin |
| 316 argument, passed through to urlSelected. |
| 317 (WebCore::FrameLoader::urlSelected): Replaced the resource request |
| 318 and frame name arguments with a frame load request arguments in one |
| 319 overload, and changed the other overload to pass in the current |
| 320 frame's document for the security origin. |
| 321 (WebCore::FrameLoader::loadFrameRequest): Moved the canDisplay |
| 322 check before the referrer computation because it no longer needs |
| 323 to look at the referrer. Replaced the call to canDisplay that |
| 324 used the target frame's security origin and the call to |
| 325 deprecatedCanDisplay with a single call to canDisplay that uses |
| 326 the requester security origin. |
| 327 |
| 328 * loader/FrameLoader.h: Updated for argument changes above. |
| 329 |
| 330 * loader/NavigationScheduler.cpp: |
| 331 (WebCore::ScheduledURLNavigation::ScheduledURLNavigation): Added |
| 332 a security origin. |
| 333 (WebCore::ScheduledURLNavigation::fire): Pass the security origin |
| 334 in to FrameLoader::changeLocation. |
| 335 (WebCore::ScheduledURLNavigation::securityOrigin): Added. |
| 336 (WebCore::ScheduledRedirect::ScheduledRedirect): Added a security |
| 337 origin argument. |
| 338 (WebCore::ScheduledLocationChange::ScheduledLocationChange): Ditto. |
| 339 (WebCore::ScheduledRefresh::ScheduledRefresh): Ditto. |
| 340 (WebCore::ScheduledRefresh::fire): Pass the security origin in to |
| 341 FrameLoader::changeLocation. |
| 342 (WebCore::ScheduledFormSubmission::fire): Include the security |
| 343 origin when constructing form submission. |
| 344 (WebCore::NavigationScheduler::scheduleRedirect): Include the security |
| 345 origin when creating the scheduled navigation object. |
| 346 (WebCore::NavigationScheduler::scheduleLocationChange): Ditto. |
| 347 (WebCore::NavigationScheduler::scheduleRefresh): Ditto. |
| 348 |
| 349 * loader/NavigationScheduler.h: Added the security origin argument |
| 350 to scheduleLocationChange. |
| 351 |
| 352 * loader/SubframeLoader.cpp: |
| 353 (WebCore::SubframeLoader::loadOrRedirectSubframe): Pass in the security |
| 354 origin when calling scheduleLocationChange. |
| 355 * loader/appcache/ApplicationCacheGroup.cpp: |
| 356 (WebCore::ApplicationCacheGroup::selectCache): Ditto. |
| 357 |
| 358 * page/ContextMenuController.cpp: |
| 359 (WebCore::openNewWindow): Pass in the security origin. |
| 360 (WebCore::ContextMenuController::contextMenuItemSelected): Ditto. |
| 361 |
| 362 * page/FrameLoadRequest.h: Added a security origin called the requester |
| 363 to all FrameLoadRequest objects. |
| 364 |
| 365 * page/XSSAuditor.cpp: |
| 366 (WebCore::XSSAuditor::findInRequest): Added the security origin. |
| 367 |
| 368 2010-12-07 Yury Semikhatsky <yurys@chromium.org> |
| 369 |
| 370 Reviewed by Pavel Feldman. |
| 371 |
| 372 Web Inspector: avoid initializing Context on when creating attaching lis
tener to ScriptDebugServer |
| 373 https://bugs.webkit.org/show_bug.cgi?id=50627 |
| 374 |
| 375 * bindings/v8/ScriptDebugServer.cpp: |
| 376 (WebCore::ScriptDebugServer::addListener): don't try to collect already
parsed scripts if context has |
| 377 not been initialized yet. |
| 378 |
| 379 2010-12-07 Csaba Osztrogonác <ossy@webkit.org> |
| 380 |
| 381 Unreviewed. Rolling out r73421, because it made transitions/color-transi
tion-all.html flakey. |
| 382 |
| 383 * page/animation/AnimationBase.cpp: |
| 384 (WebCore::addShorthandProperties): |
| 385 |
| 386 2010-12-07 Martin Robinson <mrobinson@igalia.com> |
| 387 |
| 388 Unreviewed, rolling out r73392. |
| 389 http://trac.webkit.org/changeset/73392 |
| 390 https://bugs.webkit.org/show_bug.cgi?id=50489 |
| 391 |
| 392 This commit caused crashes on the GTK+ bots |
| 393 |
| 394 * bindings/ScriptControllerBase.cpp: |
| 395 (WebCore::ScriptController::executeIfJavaScriptURL): |
| 396 * dom/Document.cpp: |
| 397 (WebCore::Document::Document): |
| 398 (WebCore::Document::close): |
| 399 (WebCore::Document::lastModified): |
| 400 (WebCore::Document::finishedParsing): |
| 401 (WebCore::Document::initSecurityContext): |
| 402 (WebCore::Document::updateURLForPushOrReplaceState): |
| 403 * dom/Document.h: |
| 404 * dom/ProcessingInstruction.cpp: |
| 405 (WebCore::ProcessingInstruction::checkStyleSheet): |
| 406 * dom/ScriptElement.cpp: |
| 407 (WebCore::ScriptElement::scriptCharset): |
| 408 * html/HTMLLinkElement.cpp: |
| 409 (WebCore::HTMLLinkElement::process): |
| 410 * html/MediaDocument.cpp: |
| 411 (WebCore::MediaDocument::replaceMediaElementTimerFired): |
| 412 * html/PluginDocument.cpp: |
| 413 (WebCore::PluginDocumentParser::createDocumentStructure): |
| 414 * loader/DocumentLoader.cpp: |
| 415 (WebCore::DocumentLoader::DocumentLoader): |
| 416 (WebCore::DocumentLoader::finishedLoading): |
| 417 (WebCore::DocumentLoader::commitData): |
| 418 (WebCore::DocumentLoader::setupForReplaceByMIMEType): |
| 419 (WebCore::DocumentLoader::setFrame): |
| 420 * loader/DocumentLoader.h: |
| 421 * loader/DocumentWriter.cpp: |
| 422 (WebCore::DocumentWriter::begin): |
| 423 * loader/DocumentWriter.h: |
| 424 * loader/FrameLoader.cpp: |
| 425 (WebCore::FrameLoader::FrameLoader): |
| 426 (WebCore::FrameLoader::init): |
| 427 (WebCore::FrameLoader::clear): |
| 428 (WebCore::FrameLoader::receivedFirstData): |
| 429 (WebCore::FrameLoader::transitionToCommitted): |
| 430 (WebCore::FrameLoader::open): |
| 431 (WebCore::FrameLoader::finishedLoadingDocument): |
| 432 (WebCore::FrameLoader::addExtraFieldsToRequest): |
| 433 * loader/FrameLoader.h: |
| 434 (WebCore::FrameLoader::writer): |
| 435 * loader/cache/CachedResourceLoader.cpp: |
| 436 (WebCore::CachedResourceLoader::requestPreload): |
| 437 * platform/network/FormDataBuilder.cpp: |
| 438 (WebCore::FormDataBuilder::encodingFromAcceptCharset): |
| 439 * svg/graphics/SVGImage.cpp: |
| 440 (WebCore::SVGImage::dataChanged): |
| 441 |
| 442 2010-12-07 Patrick Gansterer <paroga@webkit.org> |
| 443 |
| 444 Reviewed by Andreas Kling. |
| 445 |
| 446 [CMake] Remove WebKitGenerators |
| 447 https://bugs.webkit.org/show_bug.cgi?id=50445 |
| 448 |
| 449 Move remaining logic into main CMakeLists.txt. |
| 450 |
| 451 * CMakeLists.txt: |
| 452 |
| 453 2010-12-07 Justin Schuh <jschuh@chromium.org> |
| 454 |
| 455 Reviewed by Nikolas Zimmermann. |
| 456 |
| 457 Clear old SVG cursor entry before adding a new one |
| 458 https://bugs.webkit.org/show_bug.cgi?id=50549 |
| 459 |
| 460 Test: svg/css/cursor-replace.svg |
| 461 |
| 462 * css/CSSCursorImageValue.cpp: |
| 463 (WebCore::CSSCursorImageValue::~CSSCursorImageValue): |
| 464 * svg/SVGCursorElement.cpp: |
| 465 (WebCore::SVGCursorElement::~SVGCursorElement): |
| 466 (WebCore::SVGCursorElement::removeClient): |
| 467 (WebCore::SVGCursorElement::removeReferencedElement): |
| 468 * svg/SVGCursorElement.h: |
| 469 * svg/SVGElement.cpp: |
| 470 (WebCore::SVGElement::setCursorElement): |
| 471 (WebCore::SVGElement::cursorElementRemoved): |
| 472 (WebCore::SVGElement::setCursorImageValue): |
| 473 (WebCore::SVGElement::cursorImageElementRemoved): |
| 474 * svg/SVGElement.h: |
| 475 |
| 476 2010-12-07 Kenichi Ishibashi <bashi@google.com> |
| 477 |
| 478 Reviewed by Kent Tamura. |
| 479 |
| 480 Let HTMLObjectElement be a form associated element |
| 481 https://bugs.webkit.org/show_bug.cgi?id=48821 |
| 482 |
| 483 Introduces FormAssociatedElement class which would be a super class |
| 484 of form assocated elements. Some of member functions and variables of |
| 485 HTMLFormControlElement are migrated into this class. |
| 486 Following the HTML5 spec, HTMLFormControlElement class and |
| 487 HTMLObjectElement class are subclasses of it for now. |
| 488 |
| 489 Test: fast/forms/form-collection-elements-order.html |
| 490 |
| 491 * Android.mk: Added FormAssociatedElement.cpp |
| 492 * CMakeLists.txt: Ditto. |
| 493 * GNUmakefile.am: Added FormAssociatedElement.{cpp,h} |
| 494 * WebCore.exp.in: Added the symbol for toHTMLElement(FormAssociatedEleme
nt*) |
| 495 * WebCore.gypi: Added FormAssociatedElement.{cpp,h} |
| 496 * WebCore.pro: Ditto. |
| 497 * WebCore.vcproj/WebCore.vcproj: Ditto. |
| 498 * WebCore.xcodeproj/project.pbxproj: Ditto. |
| 499 * dom/CheckedRadioButtons.h: Fixed class forward declaration order. |
| 500 * dom/Document.cpp: |
| 501 (WebCore::Document::registerFormElementWithFormAttribute): Modified to |
| 502 use FormAssociatedElement instead of HTMLFormControlElement |
| 503 (WebCore::Document::unregisterFormElementWithFormAttribute): Ditto. |
| 504 (WebCore::Document::resetFormElementsOwner): |
| 505 * dom/Document.h: Ditto. |
| 506 * html/DOMFormData.cpp: Ditto. |
| 507 (WebCore::DOMFormData::DOMFormData): |
| 508 * html/FormAssociatedElement.cpp: Copied and renamed from WebCore/html/H
TMLFormControlElement.cpp. |
| 509 (WebCore::FormAssociatedElement::FormAssociatedElement): |
| 510 (WebCore::FormAssociatedElement::~FormAssociatedElement): |
| 511 (WebCore::FormAssociatedElement::validity): |
| 512 (WebCore::FormAssociatedElement::insertedIntoTree): |
| 513 (WebCore::FormAssociatedElement::removedFromTree): |
| 514 (WebCore::FormAssociatedElement::removeFromForm): |
| 515 (WebCore::FormAssociatedElement::resetFormOwner): |
| 516 (WebCore::FormAssociatedElement::formAttributeChanged): |
| 517 (WebCore::toHTMLElement): |
| 518 * html/FormAssociatedElement.h: Ditto. |
| 519 (WebCore::FormAssociatedElement::ref): |
| 520 (WebCore::FormAssociatedElement::deref): |
| 521 (WebCore::FormAssociatedElement::formDestroyed): |
| 522 (WebCore::FormAssociatedElement::setForm): |
| 523 * html/HTMLElement.h: Changed the access level of findFormAncestor(). |
| 524 * html/HTMLFormCollection.cpp: |
| 525 (WebCore::HTMLFormCollection::item): Modified to use FormAssociatedEleme
nt |
| 526 instead of HTMLFormControlElement. |
| 527 (WebCore::HTMLFormCollection::getNamedFormItem): Ditto. |
| 528 (WebCore::HTMLFormCollection::updateNameCache): Ditto. |
| 529 * html/HTMLFormControlElement.cpp: Modified regarding with the change of
class |
| 530 hierarchy. |
| 531 (WebCore::HTMLFormControlElement::HTMLFormControlElement): |
| 532 (WebCore::HTMLFormControlElement::~HTMLFormControlElement): |
| 533 (WebCore::HTMLFormControlElement::insertedIntoTree): |
| 534 (WebCore::HTMLFormControlElement::removedFromTree): |
| 535 (WebCore::HTMLFormControlElement::supportsFocus): |
| 536 (WebCore::HTMLFormControlElement::checkValidity): |
| 537 (WebCore::HTMLFormControlElement::virtualForm): |
| 538 (WebCore::HTMLFormControlElement::isDefaultButtonForForm): |
| 539 (WebCore::HTMLFormControlElement::attributeChanged): |
| 540 * html/HTMLFormControlElement.h: Ditto. |
| 541 (WebCore::HTMLFormControlElement::form): |
| 542 (WebCore::HTMLFormControlElement::disabled): |
| 543 (WebCore::HTMLFormControlElement::type): |
| 544 (WebCore::HTMLFormControlElement::refFormAssociatedElement): |
| 545 (WebCore::HTMLFormControlElement::derefFormAssociatedElement): |
| 546 * html/HTMLFormElement.cpp: Modified to use FormAssociatedElement |
| 547 instead of HTMLFormControlElement. |
| 548 (WebCore::HTMLFormElement::submitImplicitly): |
| 549 (WebCore::HTMLFormElement::validateInteractively): |
| 550 (WebCore::HTMLFormElement::submit): |
| 551 (WebCore::HTMLFormElement::reset): |
| 552 (WebCore::HTMLFormElement::formElementIndexWithFormAttribute): |
| 553 (WebCore::HTMLFormElement::formElementIndex): |
| 554 (WebCore::HTMLFormElement::registerFormElement): |
| 555 (WebCore::HTMLFormElement::removeFormElement): |
| 556 (WebCore::HTMLFormElement::defaultButton): |
| 557 (WebCore::HTMLFormElement::checkValidity): |
| 558 (WebCore::HTMLFormElement::collectUnhandledInvalidControls): |
| 559 (WebCore::HTMLFormElement::documentDidBecomeActive): |
| 560 * html/HTMLFormElement.h: Ditto. |
| 561 (WebCore::HTMLFormElement::associatedElements): |
| 562 * html/HTMLInputElement.cpp: Ditto. |
| 563 (WebCore::HTMLInputElement::updateCheckedRadioButtons): |
| 564 * html/HTMLObjectElement.cpp: Modified regarding with the change of clas
s |
| 565 hierarchy. |
| 566 (WebCore::HTMLObjectElement::HTMLObjectElement): |
| 567 (WebCore::HTMLObjectElement::~HTMLObjectElement): |
| 568 (WebCore::HTMLObjectElement::create): |
| 569 (WebCore::HTMLObjectElement::attributeChanged): |
| 570 (WebCore::HTMLObjectElement::insertedIntoTree): |
| 571 (WebCore::HTMLObjectElement::removedFromTree): |
| 572 (WebCore::HTMLObjectElement::appendFormData): |
| 573 (WebCore::HTMLObjectElement::formControlName): |
| 574 * html/HTMLObjectElement.h: Ditto. |
| 575 (WebCore::HTMLObjectElement::form): |
| 576 (WebCore::HTMLObjectElement::isFormControlElement): |
| 577 (WebCore::HTMLObjectElement::isEnumeratable): |
| 578 (WebCore::HTMLObjectElement::refFormAssociatedElement): |
| 579 (WebCore::HTMLObjectElement::derefFormAssociatedElement): |
| 580 * html/HTMLTagNames.in: Added constructorNeedsFormElement to object tag. |
| 581 * html/ValidationMessage.cpp: Modified to use FormAssociatedElement |
| 582 instead of HTMLFormControlElement. |
| 583 (WebCore::ValidationMessage::ValidationMessage): |
| 584 (WebCore::ValidationMessage::create): |
| 585 * html/ValidationMessage.h: Ditto. |
| 586 * html/ValidityState.cpp: Ditto. |
| 587 (WebCore::ValidityState::validationMessage): |
| 588 (WebCore::ValidityState::setCustomErrorMessage): |
| 589 (WebCore::ValidityState::valueMissing): |
| 590 (WebCore::ValidityState::typeMismatch): |
| 591 (WebCore::ValidityState::patternMismatch): |
| 592 (WebCore::ValidityState::tooLong): |
| 593 (WebCore::ValidityState::rangeUnderflow): |
| 594 (WebCore::ValidityState::rangeOverflow): |
| 595 (WebCore::ValidityState::stepMismatch): |
| 596 * html/ValidityState.h: Ditto. |
| 597 (WebCore::ValidityState::create): |
| 598 (WebCore::ValidityState::ValidityState): |
| 599 * loader/FormSubmission.cpp: Ditto. |
| 600 (WebCore::FormSubmission::create): |
| 601 |
| 602 2010-12-06 Pavel Feldman <pfeldman@chromium.org> |
| 603 |
| 604 Not reviewed. Rolling out r72988 for breaking iframes. |
| 605 |
| 606 * css/CSSImportRule.cpp: |
| 607 (WebCore::CSSImportRule::insertedIntoParent): |
| 608 |
| 609 2010-12-06 Hironori Bono <hbono@chromium.org> |
| 610 |
| 611 Reviewed by David Levin. |
| 612 |
| 613 [Chromium] Refactor FontCacheChromiumWin.cpp |
| 614 https://bugs.webkit.org/show_bug.cgi?id=50611 |
| 615 |
| 616 This change just moved the helper functions for the WebCore::FontCache c
lass to the beginning of ths file. |
| 617 |
| 618 No new tests are added since this is a refactoring. |
| 619 |
| 620 * platform/graphics/chromium/FontCacheChromiumWin.cpp: |
| 621 (WebCore::fontDataFromDescriptionAndLogFont): Moved to the beginning of
the file. |
| 622 (WebCore::toGDIFontWeight): Moved to the beginning of the file. |
| 623 (WebCore::FillLogFont): Moved to the beginning of the file. |
| 624 (WebCore::TraitsInFamilyProcData::TraitsInFamilyProcData): Moved to the
beginning of the file. |
| 625 (WebCore::traitsInFamilyEnumProc): Moved to the beginning of the file. |
| 626 (WebCore::FontCache::platformInit): Moved after the static functions. |
| 627 |
1 2010-12-06 Alexey Marinichev <amarinichev@chromium.org> | 628 2010-12-06 Alexey Marinichev <amarinichev@chromium.org> |
2 | 629 |
3 Reviewed by Kenneth Russell. | 630 Reviewed by Kenneth Russell. |
4 | 631 |
5 Throw webglcontextlost and webglcontextrestored events when a WebGL cont
ext is lost and restored. | 632 Throw webglcontextlost and webglcontextrestored events when a WebGL cont
ext is lost and restored. |
6 https://bugs.webkit.org/show_bug.cgi?id=50364 | 633 https://bugs.webkit.org/show_bug.cgi?id=50364 |
7 | 634 |
8 No new tests since there is currently no way to force a context lost eve
nt. | 635 No new tests since there is currently no way to force a context lost eve
nt. |
9 | 636 |
10 * html/canvas/WebGLRenderingContext.cpp: | 637 * html/canvas/WebGLRenderingContext.cpp: |
(...skipping 739 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
750 (WebCore::ScriptCallFrame::buildInspectorObject): | 1377 (WebCore::ScriptCallFrame::buildInspectorObject): |
751 * inspector/ScriptCallFrame.h: | 1378 * inspector/ScriptCallFrame.h: |
752 (WebCore::ScriptCallFrame::sourceURL): | 1379 (WebCore::ScriptCallFrame::sourceURL): |
753 * inspector/ScriptCallStack.h: | 1380 * inspector/ScriptCallStack.h: |
754 * inspector/TimelineRecordFactory.cpp: | 1381 * inspector/TimelineRecordFactory.cpp: |
755 (WebCore::TimelineRecordFactory::createGenericRecord): | 1382 (WebCore::TimelineRecordFactory::createGenericRecord): |
756 * inspector/front-end/ConsoleView.js: | 1383 * inspector/front-end/ConsoleView.js: |
757 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): | 1384 (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement): |
758 | 1385 |
759 == Rolled over to ChangeLog-2010-12-06 == | 1386 == Rolled over to ChangeLog-2010-12-06 == |
OLD | NEW |