Implement a useful context menu for the blocked plug-in frame:...

chrome/renderer/blocked_plugin.h

Index: chrome/renderer/blocked_plugin.h
===================================================================
--- chrome/renderer/blocked_plugin.h	(revision 67601)
+++ chrome/renderer/blocked_plugin.h	(working copy)
@@ -29,10 +29,12 @@
                 const string16& message);
 
   WebViewPlugin* plugin() { return plugin_; }
+  void menuOptionSelected(unsigned id);

[brettw, 2010/12/07 06:23:56]

This should be capitalized. I'd probably also put a blank line abofe this since
it's not at all related to plugin().

[Chris Evans, 2010/12/07 15:36:14]

Done.

 
   // WebViewPlugin::Delegate methods:
   virtual void BindWebFrame(WebKit::WebFrame* frame);
   virtual void WillDestroyPlugin();
+  virtual void ShowContextMenu(const WebKit::WebMouseEvent&);
 
   // NotificationObserver methods:
   virtual void Observe(NotificationType type,
@@ -50,10 +52,14 @@
   // Load the blocked plugin.
   void LoadPlugin();
 
+  // Hide the blocked plugin.
+  void HidePlugin();
+
   RenderView* render_view_;
   WebKit::WebFrame* frame_;
   WebKit::WebPluginParams plugin_params_;
   WebViewPlugin* plugin_;
+  string16 name_;

[brettw, 2010/12/07 06:23:56]

Can you provide a comment for this? It's very generic.

[Chris Evans, 2010/12/07 15:36:14]

Done.

 
   NotificationRegistrar registrar_;
 };