Implement a useful context menu for the blocked plug-in frame:...

chrome/renderer/render_view.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/render_view.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 #include <vector>
@@ skipping 499 matching lines @@
       ALLOW_THIS_IN_INITIALIZER_LIST(page_info_method_factory_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(autofill_method_factory_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(accessibility_method_factory_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(translate_helper_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(cookie_jar_(this)),
       ALLOW_THIS_IN_INITIALIZER_LIST(
           notification_provider_(new NotificationProvider(this))),
       accessibility_ack_pending_(false),
       pending_app_icon_requests_(0),
       session_storage_namespace_id_(session_storage_namespace_id),
-      decrement_shared_popup_at_destruction_(false) {
+      decrement_shared_popup_at_destruction_(false),
+      plugin_menu_event_listener_(NULL) {
 #if defined(OS_MACOSX)
   // On Mac, the select popups are rendered by the browser.
   // Note that we don't do this in RenderMain otherwise this would not be called
   // in single-process mode.
   WebKit::WebView::setUseExternalPopupMenus(true);
 #endif
   password_autocomplete_manager_.reset(new PasswordAutocompleteManager(this));
   autofill_helper_.reset(new AutoFillHelper(this));
   page_click_tracker_.reset(new PageClickTracker(this));
   // Note that the order of insertion of the listeners is important.
@@ skipping 269 matching lines @@
   if (!found || !info.enabled)
     return NULL;
   scoped_refptr<pepper::PluginModule> pepper_module(
       PepperPluginRegistry::GetInstance()->GetModule(info.path));
   if (pepper_module)
     return CreatePepperPlugin(frame, params, info.path, pepper_module.get());
   else
     return CreateNPAPIPlugin(frame, params, info.path, mime_type);
 }
 
+void RenderView::PluginMenuEventListenerInstall(BlockedPlugin* listening) {
+  plugin_menu_event_listener_ = listening;
+}
+
+void RenderView::PluginMenuEventListenerDestroyed(BlockedPlugin* dead) {
+  if (plugin_menu_event_listener_ == dead) {

[brettw, 2010/12/07 06:23:56]

Don't use {} for single-line conditionals to match surrouding code.

[Chris Evans, 2010/12/07 15:36:14]

Done.

+    plugin_menu_event_listener_ = NULL;
+  }
+}
+
 void RenderView::RegisterPluginDelegate(WebPluginDelegateProxy* delegate) {
   plugin_delegates_.insert(delegate);
   // If the renderer is visible, set initial visibility and focus state.
   if (!is_hidden()) {
 #if defined(OS_MACOSX)
     delegate->SetContainerVisibility(true);
     if (webview() && webview()->isActive())
       delegate->SetWindowFocus(true);
 #endif
   }
@@ skipping 1564 matching lines @@
   // response as RunJavaScriptMessage.
   std::wstring ignored_result;
   SendAndRunNestedMessageLoop(new ViewHostMsg_RunBeforeUnloadConfirm(
       routing_id_, frame->url(), UTF16ToWideHack(message), &success,
       &ignored_result));
   return success;
 }
 
 void RenderView::showContextMenu(
     WebFrame* frame, const WebContextMenuData& data) {
+  plugin_menu_event_listener_ = NULL;
   ContextMenuParams params = ContextMenuParams(data);
   if (!params.misspelled_word.empty() && RenderThread::current()) {
     int misspelled_offset, misspelled_length;
     bool spelled_right = RenderThread::current()->spellchecker()->
         SpellCheckWord(
             params.misspelled_word.c_str(), params.misspelled_word.size(),
             document_tag_,
             &misspelled_offset, &misspelled_length,
             &params.dictionary_suggestions);
     if (spelled_right)
@@ skipping 2279 matching lines @@
 void RenderView::OnUpdateWebPreferences(const WebPreferences& prefs) {
   webkit_preferences_ = prefs;
   webkit_preferences_.Apply(webview());
 }
 
 void RenderView::OnSetAltErrorPageURL(const GURL& url) {
   alternate_error_page_url_ = url;
 }
 
 void RenderView::OnCustomContextMenuAction(unsigned action) {
-  webview()->performCustomContextMenuAction(action);
+  if (plugin_menu_event_listener_) {
+    plugin_menu_event_listener_->menuOptionSelected(action);
+  } else {
+    webview()->performCustomContextMenuAction(action);
+  }
 }
 
 void RenderView::OnTranslatePage(int page_id,
                                  const std::string& translate_script,
                                  const std::string& source_lang,
                                  const std::string& target_lang) {
   translate_helper_.TranslatePage(page_id, source_lang, target_lang,
                                   translate_script);
 }
 
@@ skipping 981 matching lines @@
   external_popup_menu_.reset();
 }
 #endif
 
 void RenderView::AddErrorToRootConsole(const string16& message) {
   if (webview() && webview()->mainFrame()) {
     webview()->mainFrame()->addMessageToConsole(
         WebConsoleMessage(WebConsoleMessage::LevelError, message));
   }
 }