Issue 5638002: Updating omnibox sample to use new XML formatting method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5638002: Updating omnibox sample to use new XML formatting method. (Closed)

Created:
10 years ago by kurrik.chromium

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Erik does not do reviews, pam+watch_chromium.org, Aaron Boodman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Updating omnibox sample to use new XML formatting method. BUG=65684 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68743

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -70 lines)			Patch
	chrome/common/extensions/docs/examples/api/omnibox/extension-docs.zip	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/common/extensions/docs/examples/api/omnibox/extension-docs/background.html	View	1	6 chunks	+28 lines, -70 lines	0 comments	Download
M	chrome/common/extensions/docs/samples.json	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

kurrik.chromium

Here's the updated omnibox sample. Removed more than I added - a good sign, right?

10 years ago (2010-12-07 01:06:59 UTC) #1

Aaron Boodman

10 years ago (2010-12-07 02:16:00 UTC) #2

On 2010/12/07 01:06:59, kurrik.chromium wrote:
> Here's the updated omnibox sample.  Removed more than I added - a good sign,
> right?

Yep, LGTM