Issue 5636001: On Chrome OS, use the application locale to determine the default paper size ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 5636001: On Chrome OS, use the application locale to determine the default paper size ... (Closed)

Created:
10 years ago by sanjeevr

Modified:
9 years, 7 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews, ben+cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

On Chrome OS, use the application locale to determine the default paper size rather than rely on GTK. BUG=None. TEST=Web pages printed from Chrome OS should use locale-specific default paper size (specifically, for US, it should use 8.5 x 11). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=68233

Patch Set 1 #

Patch Set 2 : Lint errors fixed #

Patch Set 3 : Lint errors fixed #

Patch Set 4 : Windows compile error fixed #

Total comments: 2

Patch Set 5 : Review comments addressed #

Created: 10 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -22 lines)			Patch
M	chrome/browser/printing/print_job_worker.cc	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/emf_win_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context.h	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	printing/printing_context.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	printing/printing_context_cairo.h	View	1 2	1 chunk	+3 lines, -1 line	0 comments	Download
M	printing/printing_context_cairo.cc	View	1 2 3 4	3 chunks	+47 lines, -3 lines	0 comments	Download
M	printing/printing_context_mac.h	View	1	2 chunks	+3 lines, -1 line	0 comments	Download
M	printing/printing_context_mac.mm	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	printing/printing_context_win.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	printing/printing_context_win.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	printing/printing_context_win_unittest.cc	View	1 2 3	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jungshik at Google

10 years ago (2010-12-03 19:34:55 UTC) #2

LGTM with minor nits below.

http://codereview.chromium.org/5636001/diff/33001/printing/printing_context_c...
File printing/printing_context_cairo.cc (right):

http://codereview.chromium.org/5636001/diff/33001/printing/printing_context_c...
printing/printing_context_cairo.cc:10: #include <unicode/uset.h>
nit: Do you need to include uset.h? I guess not.

http://codereview.chromium.org/5636001/diff/33001/printing/printing_context_c...
printing/printing_context_cairo.cc:49: // dialog and this code.
Can you also mention that relying on app_locale does not work when a user uses,
says, Chinese ChromeOS in the US?

Expand Messages | Collapse Messages